Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 149703002: Cast: Refactor Audio Receiver to Clang format (Closed)

Created:
6 years, 10 months ago by mikhal1
Modified:
6 years, 10 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Cast: Refactor Audio Receiver to Clang format This cl is pure style-targeted refactoring. No functional changes were made. BUG=339176 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247908

Patch Set 1 #

Total comments: 6

Patch Set 2 : Responding to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -173 lines) Patch
M media/cast/audio_receiver/audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/audio_receiver/audio_decoder.cc View 5 chunks +15 lines, -8 lines 0 comments Download
M media/cast/audio_receiver/audio_decoder_unittest.cc View 7 chunks +33 lines, -35 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver.h View 3 chunks +4 lines, -2 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver.cc View 1 21 chunks +131 lines, -93 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver_unittest.cc View 12 chunks +41 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mikhal1
Please review, -Mikhal
6 years, 10 months ago (2014-01-29 19:34:35 UTC) #1
hubbe
LGTM Lots of improvements. There are a few places where I would keep the original ...
6 years, 10 months ago (2014-01-29 20:07:38 UTC) #2
mikhal1
https://chromiumcodereview.appspot.com/149703002/diff/1/media/cast/audio_receiver/audio_decoder_unittest.cc File media/cast/audio_receiver/audio_decoder_unittest.cc (right): https://chromiumcodereview.appspot.com/149703002/diff/1/media/cast/audio_receiver/audio_decoder_unittest.cc#newcode85 media/cast/audio_receiver/audio_decoder_unittest.cc:85: EXPECT_FALSE(audio_decoder_->GetRawAudioFrame( Apparently the tool prefers everything in one line ...
6 years, 10 months ago (2014-01-29 21:02:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/149703002/20001
6 years, 10 months ago (2014-01-29 21:06:18 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253788
6 years, 10 months ago (2014-01-29 22:58:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/149703002/20001
6 years, 10 months ago (2014-01-29 23:04:56 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 09:04:12 UTC) #7
Message was sent while issue was closed.
Change committed as 247908

Powered by Google App Engine
This is Rietveld 408576698