Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4391)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 2c10a2fddc5da0ca3308550895b1434d171be0cc..d89e2c7496d91e31cd9ccc9f5ba3c177d969eee8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -7,7 +7,6 @@ package org.chromium.chrome.browser.ntp;
import android.app.Activity;
import android.app.Dialog;
import android.content.Context;
-import android.graphics.Bitmap;
import android.graphics.Canvas;
import android.graphics.Color;
import android.graphics.Rect;
@@ -35,7 +34,6 @@ import org.chromium.chrome.browser.favicon.FaviconHelper.IconAvailabilityCallbac
import org.chromium.chrome.browser.favicon.LargeIconBridge;
import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;
import org.chromium.chrome.browser.metrics.StartupMetrics;
-import org.chromium.chrome.browser.ntp.BookmarksPage.BookmarkSelectedListener;
import org.chromium.chrome.browser.ntp.LogoBridge.Logo;
import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
@@ -164,20 +162,6 @@ public class NewTabPage
return url != null && url.startsWith(UrlConstants.NTP_URL);
}
- public static void launchBookmarksDialog(Activity activity, Tab tab,
- TabModelSelector tabModelSelector) {
- if (!EnhancedBookmarkUtils.showEnhancedBookmarkIfEnabled(activity)) {
- BookmarkDialogSelectedListener listener = new BookmarkDialogSelectedListener(tab);
- NativePage page = BookmarksPage.buildPageInDocumentMode(
- activity, tab, tabModelSelector, Profile.getLastUsedProfile(),
- listener);
- page.updateForUrl(UrlConstants.BOOKMARKS_URL);
- Dialog dialog = new NativePageDialog(activity, page);
- listener.setDialog(dialog);
- dialog.show();
- }
- }
-
public static void launchRecentTabsDialog(Activity activity, Tab tab) {
DocumentRecentTabsManager manager = new DocumentRecentTabsManager(tab, activity);
NativePage page = new RecentTabsPage(activity, manager);
@@ -305,11 +289,7 @@ public class NewTabPage
public void navigateToBookmarks() {
if (mIsDestroyed) return;
RecordUserAction.record("MobileNTPSwitchToBookmarks");
- if (FeatureUtilities.isDocumentMode(mActivity)) {
- launchBookmarksDialog(mActivity, mTab, mTabModelSelector);
- } else if (!EnhancedBookmarkUtils.showEnhancedBookmarkIfEnabled(mActivity)) {
- mTab.loadUrl(new LoadUrlParams(UrlConstants.BOOKMARKS_URL));
- }
+ EnhancedBookmarkUtils.showEnhancedBookmarks(mActivity);
}
@Override
@@ -679,28 +659,4 @@ public class NewTabPage
public void captureThumbnail(Canvas canvas) {
mNewTabPageView.captureThumbnail(canvas);
}
-
- private static class BookmarkDialogSelectedListener implements BookmarkSelectedListener {
- private Dialog mDialog;
- private final Tab mTab;
-
- public BookmarkDialogSelectedListener(Tab tab) {
- mTab = tab;
- }
-
- @Override
- public void onNewTabOpened() {
- if (mDialog != null) mDialog.dismiss();
- }
-
- @Override
- public void onBookmarkSelected(String url, String title, Bitmap favicon) {
- if (mDialog != null) mDialog.dismiss();
- mTab.loadUrl(new LoadUrlParams(url));
- }
-
- public void setDialog(Dialog dialog) {
- mDialog = dialog;
- }
- }
}

Powered by Google App Engine
This is Rietveld 408576698