Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java
index 16dbe7e06fc8fdaa3f57d6ac88930eb9cc75c821..127a47beb37cf739c380254b1d0ccf594a180f96 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java
@@ -22,7 +22,6 @@ import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeBrowserProviderClient;
import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.UrlConstants;
-import org.chromium.chrome.browser.bookmark.BookmarksBridge;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
import org.chromium.chrome.browser.enhancedbookmarks.EnhancedBookmarksModel.AddBookmarkCallback;
import org.chromium.chrome.browser.favicon.FaviconHelper;
@@ -50,13 +49,6 @@ public class EnhancedBookmarkUtils {
private static final String PREF_LAST_USED_URL = "enhanced_bookmark_last_used_url";
/**
- * @return True if enhanced bookmark feature is enabled.
- */
- public static boolean isEnhancedBookmarkEnabled() {
- return BookmarksBridge.isEnhancedBookmarksEnabled();
- }
-
- /**
* If the tab has already been bookmarked, start {@link EnhancedBookmarkEditActivity} for the
* bookmark. If not, add the bookmark to bookmarkmodel, and show a snackbar notifying the user.
* @param idToAdd The bookmark ID if the tab has already been bookmarked.
@@ -259,14 +251,9 @@ public class EnhancedBookmarkUtils {
}
/**
- * Shows enhanced bookmark main UI, if it is turned on. Does nothing if it is turned off.
- * @return True if enhanced bookmark is on, false otherwise.
+ * Shows enhanced bookmark main UI.
*/
- public static boolean showEnhancedBookmarkIfEnabled(Activity activity) {
- if (!isEnhancedBookmarkEnabled()) {
- return false;
- }
-
+ public static void showEnhancedBookmarks(Activity activity) {
Ian Wen 2015/12/04 04:28:58 Rename to showBookmarkManager() or startBookmarkMa
Kibeom Kim (inactive) 2015/12/04 21:07:52 Done.
String url = getFirstUrlToLoad(activity);
if (DeviceFormFactor.isTablet(activity)) {
@@ -276,7 +263,6 @@ public class EnhancedBookmarkUtils {
intent.setData(Uri.parse(url));
activity.startActivity(intent);
}
- return true;
}
/**

Powered by Google App Engine
This is Rietveld 408576698