chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java - Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java » ('j') | components/enhanced_bookmarks/enhanced_bookmark_features.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

index 2c10a2fddc5da0ca3308550895b1434d171be0cc..285876eea7582dde36871776f8ac0330b48ff764 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

@@ -166,16 +166,7 @@ public class NewTabPage

public static void launchBookmarksDialog(Activity activity, Tab tab,

TabModelSelector tabModelSelector) {

- if (!EnhancedBookmarkUtils.showEnhancedBookmarkIfEnabled(activity)) {

- BookmarkDialogSelectedListener listener = new BookmarkDialogSelectedListener(tab);

- NativePage page = BookmarksPage.buildPageInDocumentMode(

- activity, tab, tabModelSelector, Profile.getLastUsedProfile(),

- listener);

- page.updateForUrl(UrlConstants.BOOKMARKS_URL);

- Dialog dialog = new NativePageDialog(activity, page);

- listener.setDialog(dialog);

- dialog.show();

- }

+ EnhancedBookmarkUtils.showEnhancedBookmarkIfEnabled(activity);

}

public static void launchRecentTabsDialog(Activity activity, Tab tab) {

@@ -305,11 +296,7 @@ public class NewTabPage

public void navigateToBookmarks() {

if (mIsDestroyed) return;

RecordUserAction.record("MobileNTPSwitchToBookmarks");

- if (FeatureUtilities.isDocumentMode(mActivity)) {

- launchBookmarksDialog(mActivity, mTab, mTabModelSelector);

- } else if (!EnhancedBookmarkUtils.showEnhancedBookmarkIfEnabled(mActivity)) {

- mTab.loadUrl(new LoadUrlParams(UrlConstants.BOOKMARKS_URL));

- }

+ EnhancedBookmarkUtils.showEnhancedBookmarkIfEnabled(mActivity);

}

@Override