chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java - Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase & ios update Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

index cd9b8d4064b8902f466cf71c9604b90950022281..45411aa63f22418d7564566740557318e145d94e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

@@ -12,7 +12,6 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

import org.chromium.base.metrics.RecordHistogram;

-import org.chromium.chrome.browser.bookmark.BookmarksBridge;

import org.chromium.chrome.browser.profiles.Profile;

import org.chromium.components.bookmarks.BookmarkId;

import org.chromium.components.bookmarks.BookmarkType;

@@ -164,11 +163,7 @@ public final class OfflinePageBridge {

public static boolean isEnabled() {

ThreadUtils.assertOnUiThread();

- if (sIsEnabled == null) {

- // Enhanced bookmarks feature should also be enabled.

- sIsEnabled = nativeIsOfflinePagesEnabled()

- && BookmarksBridge.isEnhancedBookmarksEnabled();

- }

+ if (sIsEnabled == null) sIsEnabled = nativeIsOfflinePagesEnabled();

return sIsEnabled;

}