Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: chrome/browser/android/bookmarks/bookmarks_bridge.cc

Issue 1496953003: [Enhanced Bookmarks] Make enhanced bookmarks default for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/bookmarks/bookmarks_bridge.h" 5 #include "chrome/browser/android/bookmarks/bookmarks_bridge.h"
6 6
7 #include "base/android/jni_array.h" 7 #include "base/android/jni_array.h"
8 #include "base/android/jni_string.h" 8 #include "base/android/jni_string.h"
9 #include "base/containers/stack_container.h" 9 #include "base/containers/stack_container.h"
10 #include "base/i18n/string_compare.h" 10 #include "base/i18n/string_compare.h"
11 #include "base/prefs/pref_service.h" 11 #include "base/prefs/pref_service.h"
12 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 12 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
13 #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h" 13 #include "chrome/browser/bookmarks/managed_bookmark_service_factory.h"
14 #include "chrome/browser/profiles/incognito_helpers.h" 14 #include "chrome/browser/profiles/incognito_helpers.h"
15 #include "chrome/browser/profiles/profile.h" 15 #include "chrome/browser/profiles/profile.h"
16 #include "chrome/browser/profiles/profile_android.h" 16 #include "chrome/browser/profiles/profile_android.h"
17 #include "chrome/browser/signin/signin_manager_factory.h" 17 #include "chrome/browser/signin/signin_manager_factory.h"
18 #include "chrome/browser/undo/bookmark_undo_service_factory.h" 18 #include "chrome/browser/undo/bookmark_undo_service_factory.h"
19 #include "components/bookmarks/browser/bookmark_match.h" 19 #include "components/bookmarks/browser/bookmark_match.h"
20 #include "components/bookmarks/browser/bookmark_model.h" 20 #include "components/bookmarks/browser/bookmark_model.h"
21 #include "components/bookmarks/browser/bookmark_utils.h" 21 #include "components/bookmarks/browser/bookmark_utils.h"
22 #include "components/bookmarks/browser/scoped_group_bookmark_actions.h" 22 #include "components/bookmarks/browser/scoped_group_bookmark_actions.h"
23 #include "components/bookmarks/common/android/bookmark_type.h" 23 #include "components/bookmarks/common/android/bookmark_type.h"
24 #include "components/bookmarks/common/bookmark_pref_names.h" 24 #include "components/bookmarks/common/bookmark_pref_names.h"
25 #include "components/bookmarks/managed/managed_bookmark_service.h" 25 #include "components/bookmarks/managed/managed_bookmark_service.h"
26 #include "components/enhanced_bookmarks/enhanced_bookmark_features.h"
27 #include "components/query_parser/query_parser.h" 26 #include "components/query_parser/query_parser.h"
28 #include "components/signin/core/browser/signin_manager.h" 27 #include "components/signin/core/browser/signin_manager.h"
29 #include "components/undo/bookmark_undo_service.h" 28 #include "components/undo/bookmark_undo_service.h"
30 #include "components/undo/undo_manager.h" 29 #include "components/undo/undo_manager.h"
31 #include "content/public/browser/browser_thread.h" 30 #include "content/public/browser/browser_thread.h"
32 #include "grit/components_strings.h" 31 #include "grit/components_strings.h"
33 #include "jni/BookmarksBridge_jni.h" 32 #include "jni/BookmarksBridge_jni.h"
34 #include "ui/base/l10n/l10n_util.h" 33 #include "ui/base/l10n/l10n_util.h"
35 34
36 using base::android::AttachCurrentThread; 35 using base::android::AttachCurrentThread;
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 return RegisterNativesImpl(env); 133 return RegisterNativesImpl(env);
135 } 134 }
136 135
137 static jlong Init(JNIEnv* env, 136 static jlong Init(JNIEnv* env,
138 const JavaParamRef<jobject>& obj, 137 const JavaParamRef<jobject>& obj,
139 const JavaParamRef<jobject>& j_profile) { 138 const JavaParamRef<jobject>& j_profile) {
140 BookmarksBridge* delegate = new BookmarksBridge(env, obj, j_profile); 139 BookmarksBridge* delegate = new BookmarksBridge(env, obj, j_profile);
141 return reinterpret_cast<intptr_t>(delegate); 140 return reinterpret_cast<intptr_t>(delegate);
142 } 141 }
143 142
144 static jboolean IsEnhancedBookmarksFeatureEnabled(
145 JNIEnv* env,
146 const JavaParamRef<jclass>& clazz) {
147 return enhanced_bookmarks::IsEnhancedBookmarksEnabled();
148 }
149
150 jboolean BookmarksBridge::IsEditBookmarksEnabled( 143 jboolean BookmarksBridge::IsEditBookmarksEnabled(
151 JNIEnv* env, 144 JNIEnv* env,
152 const JavaParamRef<jobject>& obj) { 145 const JavaParamRef<jobject>& obj) {
153 return IsEditBookmarksEnabled(); 146 return IsEditBookmarksEnabled();
154 } 147 }
155 148
156 void BookmarksBridge::LoadEmptyPartnerBookmarkShimForTesting( 149 void BookmarksBridge::LoadEmptyPartnerBookmarkShimForTesting(
157 JNIEnv* env, 150 JNIEnv* env,
158 const JavaParamRef<jobject>& obj) { 151 const JavaParamRef<jobject>& obj) {
159 if (partner_bookmarks_shim_->IsLoaded()) 152 if (partner_bookmarks_shim_->IsLoaded())
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
786 DCHECK_CURRENTLY_ON(BrowserThread::UI); 779 DCHECK_CURRENTLY_ON(BrowserThread::UI);
787 DCHECK(IsLoaded()); 780 DCHECK(IsLoaded());
788 DCHECK(grouped_bookmark_actions_.get()); // should only call after start 781 DCHECK(grouped_bookmark_actions_.get()); // should only call after start
789 grouped_bookmark_actions_.reset(); 782 grouped_bookmark_actions_.reset();
790 } 783 }
791 784
792 base::string16 BookmarksBridge::GetTitle(const BookmarkNode* node) const { 785 base::string16 BookmarksBridge::GetTitle(const BookmarkNode* node) const {
793 if (partner_bookmarks_shim_->IsPartnerBookmark(node)) 786 if (partner_bookmarks_shim_->IsPartnerBookmark(node))
794 return partner_bookmarks_shim_->GetTitle(node); 787 return partner_bookmarks_shim_->GetTitle(node);
795 788
796 if (node == bookmark_model_->bookmark_bar_node() 789 if (node == bookmark_model_->bookmark_bar_node()) {
797 && enhanced_bookmarks::IsEnhancedBookmarksEnabled()) {
798 return l10n_util::GetStringUTF16(IDS_ENHANCED_BOOKMARK_BAR_FOLDER_NAME); 790 return l10n_util::GetStringUTF16(IDS_ENHANCED_BOOKMARK_BAR_FOLDER_NAME);
799 } 791 }
800 792
801 return node->GetTitle(); 793 return node->GetTitle();
802 } 794 }
803 795
804 ScopedJavaLocalRef<jobject> BookmarksBridge::CreateJavaBookmark( 796 ScopedJavaLocalRef<jobject> BookmarksBridge::CreateJavaBookmark(
805 const BookmarkNode* node) { 797 const BookmarkNode* node) {
806 JNIEnv* env = AttachCurrentThread(); 798 JNIEnv* env = AttachCurrentThread();
807 799
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
1096 BookmarkModelChanged(); 1088 BookmarkModelChanged();
1097 } 1089 }
1098 1090
1099 void BookmarksBridge::PartnerShimLoaded(PartnerBookmarksShim* shim) { 1091 void BookmarksBridge::PartnerShimLoaded(PartnerBookmarksShim* shim) {
1100 NotifyIfDoneLoading(); 1092 NotifyIfDoneLoading();
1101 } 1093 }
1102 1094
1103 void BookmarksBridge::ShimBeingDeleted(PartnerBookmarksShim* shim) { 1095 void BookmarksBridge::ShimBeingDeleted(PartnerBookmarksShim* shim) {
1104 partner_bookmarks_shim_ = NULL; 1096 partner_bookmarks_shim_ = NULL;
1105 } 1097 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698