Issue 149692: Fix auto-opening file types not auto-opening....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149692: Fix auto-opening file types not auto-opening.... (Closed)

Created:
11 years, 5 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix auto-opening file types not auto-opening. BUG=http://crbug.com/16085 TEST=As described in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20772

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/browser/download/download_manager.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

Avi (use Gerrit)

Messed this one up during my extension extensions fix. Accidentally dropped a required period drop.

11 years, 5 months ago (2009-07-15 19:34:42 UTC) #1

Erik does not do reviews

11 years, 5 months ago (2009-07-15 19:48:48 UTC) #2

LGTM

It's too bad that this functionality isn't covered in a unit test. :-(