Add a new flag to dart2js: --trust-type-annotations and implement it in the types inferrer.

Add a new flag to dart2js: --trust-type-annotations and implement it in the types inferrer.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22918

[ngeoffray, 2013-05-15 15:58:01]

Something along those lines?

[kasperl, 2013-05-16 13:17:20]

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:466:
this.trustTypeAnnotations =
Maybe keep the flags separate here, so the inferrer can use them separately if
it needs to?

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:704:
returnType = narrowType(
Couldn't you do the narrowing when you record? (like you do in
internalRecordType)

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1369:
locals[local] = type;
Shouldn't this use narrowing as well?

[ngeoffray, 2013-05-17 14:34:25]

PTAL. I now differentiate between checked mode and the experimental flag.

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:466:
this.trustTypeAnnotations =
On 2013/05/16 13:17:20, kasperl wrote:
> Maybe keep the flags separate here, so the inferrer can use them separately if
> it needs to?

Done.

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:704:
returnType = narrowType(
On 2013/05/16 13:17:20, kasperl wrote:
> Couldn't you do the narrowing when you record? (like you do in
> internalRecordType)

This is in case the element has not been analyzed yet. We just return the type
annotation.

https://codereview.chromium.org/14969040/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1369:
locals[local] = type;
On 2013/05/16 13:17:20, kasperl wrote:
> Shouldn't this use narrowing as well?

Done.

[kasperl, 2013-05-21 07:09:11]

LGTM.

[ngeoffray, 2013-05-21 07:31:17]

Committed patchset #2 manually as r22918 (presubmit successful).