Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1496873004: Fix warnings (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@analyzer-breaking-0.27
Target Ref:
refs/heads/analyzer-breaking-0.27
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
5 years ago (2015-12-03 19:58:55 UTC) #2
Paul Berry
lgtm. Though I wonder, would it be better to just remove deprecated methods like these, ...
5 years ago (2015-12-03 21:47:57 UTC) #3
Brian Wilkerson
I didn't do so in order to get the change in sooner, although that probably ...
5 years ago (2015-12-03 21:49:46 UTC) #4
Brian Wilkerson
5 years ago (2015-12-03 22:07:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
18f57826202944880cbf72130385fc95605b0037 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698