Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 149687: delegateless pump (Closed)

Created:
11 years, 5 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
John Grabowski
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

When work shows up and no delegate is available to dispatch it to, arrange to dispatch to the delegate when one becomes available. BUG=16732 TEST=rm ~/Library/Preferences/com.google.Chrome.plist, launch official-branding Google Chrome, dismiss first-run dialog. The application should be usable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -13 lines) Patch
M base/message_pump_mac.h View 1 chunk +9 lines, -0 lines 0 comments Download
M base/message_pump_mac.mm View 5 chunks +28 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years, 5 months ago (2009-07-15 18:54:39 UTC) #1
John Grabowski
11 years, 5 months ago (2009-07-15 19:37:06 UTC) #2
LGTM but please add a unit test to confirm behavior.
In the past we have had subtle problems in here.

Powered by Google App Engine
This is Rietveld 408576698