Issue 149687: delegateless pump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149687: delegateless pump (Closed)

Created:
11 years, 5 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com, brettw

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

When work shows up and no delegate is available to dispatch it to, arrange to dispatch to the delegate when one becomes available. BUG=16732 TEST=rm ~/Library/Preferences/com.google.Chrome.plist, launch official-branding Google Chrome, dismiss first-run dialog. The application should be usable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20770

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -13 lines)			Patch
	M	base/message_pump_mac.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	base/message_pump_mac.mm	View		5 chunks	+28 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

11 years, 5 months ago (2009-07-15 19:37:06 UTC) #2

LGTM but please add a unit test to confirm behavior.
In the past we have had subtle problems in here.

Expand Messages | Collapse Messages