third_party/WebKit/Source/core/style/GridResolvedPosition.h - Issue 1496863004: [css-grid] Simplify method to resolve auto-placed items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/GridResolvedPosition.h

Issue 1496863004: [css-grid] Simplify method to resolve auto-placed items (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@kill-grid-resolved-position

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutGrid.cpp ('k') | third_party/WebKit/Source/core/style/GridResolvedPosition.cpp » ('j') | third_party/WebKit/Source/core/style/GridResolvedPosition.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/GridResolvedPosition.h

diff --git a/third_party/WebKit/Source/core/style/GridResolvedPosition.h b/third_party/WebKit/Source/core/style/GridResolvedPosition.h

index 6d4a77e6ac695658d08d2e835b85cdc2ce4d79bd..1d468f04c35865cc1fb1c87ba39b495c0550941d 100644

--- a/third_party/WebKit/Source/core/style/GridResolvedPosition.h

+++ b/third_party/WebKit/Source/core/style/GridResolvedPosition.h

@@ -40,7 +40,7 @@ public:

static GridPositionSide initialPositionSide(GridTrackSizingDirection);

static GridPositionSide finalPositionSide(GridTrackSizingDirection);

- static GridSpan resolveGridPositionsFromAutoPlacementPosition(const ComputedStyle&, const LayoutBox&, GridTrackSizingDirection, size_t resolvedInitialPosition);

+ static size_t spanSizeFromAutoPlacementPosition(const ComputedStyle&, const LayoutBox&, GridTrackSizingDirection);

svillar 2015/12/04 13:28:36 I am not convinced with the naming. We are no long

Manuel Rego 2015/12/04 14:49:10 Nice suggestion, I was not convinced about the new

static GridSpan resolveGridPositionsFromStyle(const ComputedStyle&, const LayoutBox&, GridTrackSizingDirection);

};