Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(38)

Issue 1496863004: [css-grid] Simplify method to resolve auto-placed items (Closed)

Created:
3 years, 3 months ago by Manuel Rego
Modified:
3 years, 3 months ago
Reviewers:
cbiesinger, svillar, rune
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Manuel Rego, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@kill-grid-resolved-position
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Simplify method to resolve auto-placed items Refactor the method to resolve auto-placed items, for which we're only interested in knowing the span size. Adapt the calls to use the span size instead of a GridSpan. No new tests, no change of behavior. BUG=444011 Committed: https://crrev.com/302423d65cd31d4ba94cbc177612bf26f3305af6 Cr-Commit-Position: refs/heads/master@{#363457}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Applying suggested changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -23 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 6 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridResolvedPosition.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/GridResolvedPosition.cpp View 1 1 chunk +7 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
Manuel Rego
Another small refactoring. The method to resolve auto-placed items was more complex than needed. We ...
3 years, 3 months ago (2015-12-04 12:41:35 UTC) #3
svillar
layout/ lgtm (style/ looks fine too but I am not an owner of that part) ...
3 years, 3 months ago (2015-12-04 13:28:36 UTC) #4
Manuel Rego
Thanks for the review. Please @rune take a look to the /style part. Thanks. https://codereview.chromium.org/1496863004/diff/1/third_party/WebKit/Source/core/style/GridResolvedPosition.cpp ...
3 years, 3 months ago (2015-12-04 14:49:10 UTC) #5
rune
style lgtm
3 years, 3 months ago (2015-12-07 10:45:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496863004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496863004/20001
3 years, 3 months ago (2015-12-07 11:10:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 3 months ago (2015-12-07 12:25:59 UTC) #11
commit-bot: I haz the power
3 years, 3 months ago (2015-12-07 12:27:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/302423d65cd31d4ba94cbc177612bf26f3305af6
Cr-Commit-Position: refs/heads/master@{#363457}

Powered by Google App Engine
This is Rietveld 408576698