[css-grid] Simplify method to resolve auto-placed items

[css-grid] Simplify method to resolve auto-placed items

Refactor the method to resolve auto-placed items,
for which we're only interested in knowing the span size.

Adapt the calls to use the span size instead of a GridSpan.

No new tests, no change of behavior.

BUG=444011
Committed: https://crrev.com/302423d65cd31d4ba94cbc177612bf26f3305af6
Cr-Commit-Position: refs/heads/master@{#363457}

[Manuel Rego, 2015-12-04 12:41:12]

Description was changed from

==========
[css-grid] Refactor method to resolved auto-placed items

Simplify the method to resolve auto-placed items,
for which we're only interested in knowing the span size.

Adapt the calls to use the span size instead of a GridSpan.

No new tests, no change of behavior.

BUG=444011
==========

to

==========
[css-grid] Simplify method to resolve auto-placed items

Refactor the method to resolve auto-placed items,
for which we're only interested in knowing the span size.

Adapt the calls to use the span size instead of a GridSpan.

No new tests, no change of behavior.

BUG=444011
==========

[Manuel Rego, 2015-12-04 12:41:35]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, rune@opera.com, svillar@igalia.com

[Manuel Rego, 2015-12-04 12:41:35]

Another small refactoring.

The method to resolve auto-placed items was more complex than needed.
We just care about the span size so we can simplify it.

BTW, this patch has been done on top of
https://codereview.chromium.org/1500433003/
So it needs to wait for that one to land first.

[svillar, 2015-12-04 13:28:36]

layout/ lgtm (style/ looks fine too but I am not an owner of that part)

https://codereview.chromium.org/1496863004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridResolvedPosition.cpp (right):

https://codereview.chromium.org/1496863004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridResolvedPosition.cpp:172: return
spanPosition.spanPosition();
This is terribly confusing. We should use some other names.

https://codereview.chromium.org/1496863004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridResolvedPosition.h (right):

https://codereview.chromium.org/1496863004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridResolvedPosition.h:43: static size_t
spanSizeFromAutoPlacementPosition(const ComputedStyle&, const LayoutBox&,
GridTrackSizingDirection);
I am not convinced with the naming. We are no longer passing an auto placement
position so having the FromAutoPlacementPosition seems wrong to me. What about
spanSizeForAutoPlacedItem for example?

[Manuel Rego, 2015-12-04 14:49:10]

Thanks for the review.

Please @rune take a look to the /style part. Thanks.

https://codereview.chromium.org/1496863004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridResolvedPosition.cpp (right):

https://codereview.chromium.org/1496863004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridResolvedPosition.cpp:172: return
spanPosition.spanPosition();
On 2015/12/04 13:28:36, svillar wrote:
> This is terribly confusing. We should use some other names.

True, I've changed it for "position".

https://codereview.chromium.org/1496863004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/style/GridResolvedPosition.h (right):

https://codereview.chromium.org/1496863004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/style/GridResolvedPosition.h:43: static size_t
spanSizeFromAutoPlacementPosition(const ComputedStyle&, const LayoutBox&,
GridTrackSizingDirection);
On 2015/12/04 13:28:36, svillar wrote:
> I am not convinced with the naming. We are no longer passing an auto placement
> position so having the FromAutoPlacementPosition seems wrong to me. What about
> spanSizeForAutoPlacedItem for example?

Nice suggestion, I was not convinced about the new name either.

[rune, 2015-12-07 10:45:02]

style lgtm

[Manuel Rego, 2015-12-07 11:08:50]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2015-12-07 11:08:50]

The patchset sent to the CQ was uploaded after l-g-t-m from svillar@igalia.com
Link to the patchset: https://codereview.chromium.org/1496863004/#ps20001
(title: "Applying suggested changes")

[commit-bot: I haz the power, 2015-12-07 11:10:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496863004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496863004/20001

[commit-bot: I haz the power, 2015-12-07 12:25:58]

Description was changed from

==========
[css-grid] Simplify method to resolve auto-placed items

Refactor the method to resolve auto-placed items,
for which we're only interested in knowing the span size.

Adapt the calls to use the span size instead of a GridSpan.

No new tests, no change of behavior.

BUG=444011
==========

to

==========
[css-grid] Simplify method to resolve auto-placed items

Refactor the method to resolve auto-placed items,
for which we're only interested in knowing the span size.

Adapt the calls to use the span size instead of a GridSpan.

No new tests, no change of behavior.

BUG=444011
==========

[commit-bot: I haz the power, 2015-12-07 12:25:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-07 12:27:03]

Description was changed from

==========
[css-grid] Simplify method to resolve auto-placed items

Refactor the method to resolve auto-placed items,
for which we're only interested in knowing the span size.

Adapt the calls to use the span size instead of a GridSpan.

No new tests, no change of behavior.

BUG=444011
==========

to

==========
[css-grid] Simplify method to resolve auto-placed items

Refactor the method to resolve auto-placed items,
for which we're only interested in knowing the span size.

Adapt the calls to use the span size instead of a GridSpan.

No new tests, no change of behavior.

BUG=444011

Committed: https://crrev.com/302423d65cd31d4ba94cbc177612bf26f3305af6
Cr-Commit-Position: refs/heads/master@{#363457}
==========

[commit-bot: I haz the power, 2015-12-07 12:27:04]

Patchset 2 (id:??) landed as
https://crrev.com/302423d65cd31d4ba94cbc177612bf26f3305af6
Cr-Commit-Position: refs/heads/master@{#363457}