Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1496843004: PPC: [crankshaft] Deoptimize if HHasInPrototypeChainAndBranch hits a proxy. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [crankshaft] Deoptimize if HHasInPrototypeChainAndBranch hits a proxy. Port a330af0ed1f237ba17ac2242ce16cad5616c0597 Original commit message: The optimized code generated by Crankshaft cannot properly deal with proxies (in the prototype chain), and there's probably no point in trying to make that work^Wfast with Crankshaft at all. TurboFan will handle that properly; Crankshaft just bails out to fullcodegen, which then goes to the runtime, which should do the right thing soon. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:1543 LOG=n Committed: https://crrev.com/90e4179f2d005de3d4b302cea1b0fb59a9242b5c Cr-Commit-Position: refs/heads/master@{#32583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-03 15:55:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496843004/1
5 years ago (2015-12-03 16:02:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 16:46:57 UTC) #5
john.yan
lgtm
5 years ago (2015-12-03 18:50:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496843004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496843004/1
5 years ago (2015-12-03 18:51:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 19:35:44 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 19:36:36 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90e4179f2d005de3d4b302cea1b0fb59a9242b5c
Cr-Commit-Position: refs/heads/master@{#32583}

Powered by Google App Engine
This is Rietveld 408576698