Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 149683003: PWN third_party/google_toolbox_for_mac (Closed)

Created:
6 years, 10 months ago by Mark Mentovai
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + third_party/google_toolbox_for_mac/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mark Mentovai
6 years, 10 months ago (2014-01-29 19:10:41 UTC) #1
Avi (use Gerrit)
Toss my name in the file for old-time's sake.
6 years, 10 months ago (2014-01-29 19:11:47 UTC) #2
Mark Mentovai
OK
6 years, 10 months ago (2014-01-29 19:13:11 UTC) #3
Robert Sesek
This should be named right: OWNERS.
6 years, 10 months ago (2014-01-29 19:53:53 UTC) #4
Mark Mentovai
Good catch :)
6 years, 10 months ago (2014-01-29 19:59:13 UTC) #5
Robert Sesek
lgtm
6 years, 10 months ago (2014-01-29 19:59:52 UTC) #6
Mark Mentovai
+darin
6 years, 10 months ago (2014-01-29 20:02:46 UTC) #7
darin (slow to review)
LGTM, thanks!
6 years, 10 months ago (2014-01-29 20:32:53 UTC) #8
Mark Mentovai
6 years, 10 months ago (2014-01-29 20:34:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r247736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698