Glue code to connect PPAPI proxy to MediaStream sources and destinations.

content/renderer/pepper/pepper_video_destination_host.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_video_destination_host.h"
 
 #include "content/public/renderer/renderer_ppapi_host.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/host/dispatch_host_message.h"
 #include "ppapi/host/host_message_context.h"
@@ skipping 33 matching lines @@
   IPC_END_MESSAGE_MAP()
   return PP_ERROR_FAILED;
 }
 
 int32_t PepperVideoDestinationHost::OnHostMsgOpen(
     HostMessageContext* context,
     const std::string& stream_url) {
   GURL gurl(stream_url);
   if (!gurl.is_valid())
     return PP_ERROR_BADARGUMENT;
-  // TODO(ronghuawu) Check that gurl is a valid MediaStream video track URL.
-  // TODO(ronghuawu) Open a MediaStream video track.
+
+  stream_url_ = gurl.spec();

[Ronghua Wu (Left Chromium), 2013/05/05 15:39:35]

stream_url_ doesn't seem be used anywhere else outside this function

[bbudge, 2013/05/06 04:02:15]

Done. I removed it since it isn't needed after opening.

+  content::FrameWriterInterface* frame_writer = NULL;
+  if (!VideoDestinationHandler::Open(NULL /* factory */,
+                                     NULL /* registry */,
+                                     stream_url_,
+                                     &frame_writer))
+    return PP_ERROR_FAILED;
+  frame_writer_.reset(frame_writer);
+
   ReplyMessageContext reply_context = context->MakeReplyMessageContext();
   reply_context.params.set_result(PP_OK);
   host()->SendReply(reply_context,
                     PpapiPluginMsg_VideoDestination_OpenReply());
   return PP_OK_COMPLETIONPENDING;
 }
 
 int32_t PepperVideoDestinationHost::OnHostMsgPutFrame(
     HostMessageContext* context,
-    const ppapi::HostResource& image_data,
+    const ppapi::HostResource& image_data_resource,
     PP_TimeTicks timestamp) {
   ppapi::thunk::EnterResourceNoLock<ppapi::thunk::PPB_ImageData_API> enter(
-      image_data.host_resource(), true);
+      image_data_resource.host_resource(), true);
   if (enter.failed())
     return PP_ERROR_BADRESOURCE;
-  webkit::ppapi::PPB_ImageData_Impl* image_resource =
+  webkit::ppapi::PPB_ImageData_Impl* image_data_impl =
       static_cast<webkit::ppapi::PPB_ImageData_Impl*>(enter.object());
 
   if (!webkit::ppapi::PPB_ImageData_Impl::IsImageDataFormatSupported(
-          image_resource->format()))
+          image_data_impl->format()))
     return PP_ERROR_BADARGUMENT;
 
-  // TODO(ronghuawu) write image data to MediaStream video track.
+  if (!frame_writer_.get())
+    return PP_ERROR_FAILED;
+
+  int64_t timestamp_ns =
+      static_cast<int64_t>(timestamp) * talk_base::kNumNanosecsPerSec;

[Ronghua Wu (Left Chromium), 2013/05/05 15:39:35]

Can you confirm the |timestamp|'s unit is second? Seems be huge for time stamp.

If this is actually the case, maybe we should just use the current time as the
timestamp.

[bbudge, 2013/05/06 04:02:15]

The value is in seconds, but held in a double so fractions of a second are
possible. It is awkward but matches the time unit used for input events from
Webkit.

[Ronghua Wu (Left Chromium), 2013/05/06 04:42:07]

Then you probably want to do the cast after convert it to nonsec.

[bbudge, 2013/05/06 19:27:50]

Good catch. Done.

+  frame_writer_->PutFrame(image_data_impl, timestamp_ns);
+
   return PP_OK;
 }
 
 int32_t PepperVideoDestinationHost::OnHostMsgClose(
     HostMessageContext* context) {
-  // TODO(ronghuawu) Close the video stream.
+  frame_writer_.reset(NULL);
   return PP_OK;
 }
 
 }  // namespace content