Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 149675: DevTools: Initial commit with docked devtools window support on Linux. (Closed)

Created:
11 years, 5 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
tony, Evan Stade
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

DevTools: Initial commit with docked devtools window support on Linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20861

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 10

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -13 lines) Patch
M chrome/browser/gtk/browser_window_gtk.h View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 2 3 4 6 chunks +38 lines, -2 lines 0 comments Download
M chrome/browser/gtk/tab_contents_container_gtk.h View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/gtk/tab_contents_container_gtk.cc View 1 2 3 4 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pfeldman
Hi guys, could you take a look at this? Comments, suggestions are welcome! Pavel
11 years, 5 months ago (2009-07-15 17:42:39 UTC) #1
tony
http://codereview.chromium.org/149675/diff/1005/24 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/149675/diff/1005/24#newcode923 Line 923: bool should_show = old_devtools == NULL && devtools_contents ...
11 years, 5 months ago (2009-07-15 17:58:47 UTC) #2
pfeldman
Thanks for your review. There are couple of questions inside, would appreciate your hints! http://codereview.chromium.org/149675/diff/1005/24 ...
11 years, 5 months ago (2009-07-15 18:24:50 UTC) #3
tony
On 2009/07/15 18:24:50, pfeldman wrote: > http://codereview.chromium.org/149675/diff/1005/24 > File chrome/browser/gtk/browser_window_gtk.cc (right): > > http://codereview.chromium.org/149675/diff/1005/24#newcode923 > ...
11 years, 5 months ago (2009-07-15 18:46:59 UTC) #4
Evan Stade
lgtm with nit http://codereview.chromium.org/149675/diff/1005/24 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/149675/diff/1005/24#newcode923 Line 923: bool should_show = old_devtools == ...
11 years, 5 months ago (2009-07-15 18:55:01 UTC) #5
pfeldman
http://codereview.chromium.org/149675/diff/1005/24 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/149675/diff/1005/24#newcode923 Line 923: bool should_show = old_devtools == NULL && devtools_contents ...
11 years, 5 months ago (2009-07-16 09:20:26 UTC) #6
Evan Stade
11 years, 5 months ago (2009-07-16 17:57:08 UTC) #7
thanks, lgtm

Powered by Google App Engine
This is Rietveld 408576698