chrome/common/extensions/docs/templates/private/api_property.html - Issue 149673004: Rework API reference pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/api_property.html

Issue 149673004: Rework API reference pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed reviewer comments from CL 121713002 Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/templates/private/api.html ('K') | « chrome/common/extensions/docs/templates/private/api.html ('k') | chrome/common/extensions/docs/templates/private/api_reference.html » ('j') | chrome/common/extensions/docs/templates/private/api_summary.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {{#property}}	1 {{#property}}

2 <div>	2 <tr>

3 <h3 id="{{id}}">{{name}}</h3>	3 <td>{{+partials.type_name link:link type:property/}}</td>

4 <div class="summary">	4 <td><code id="{{id}}">{{api.namespace}}.{{name}}</code></td>

5 <div class="line">{{api.namespace}}.{{name}}</div>	5 <td>

6 </div>

7 <div>

8 <dt><span class="property">{{name}}</span> {{+partials.type_name link:link t ype:property/}}</dt>

9 {{?deprecated +partials.warning_deprecated item:property /}}	6 {{?deprecated +partials.warning_deprecated item:property /}}

10 {{?description}}<dd>	7 {{?description}}

11 {{{description}}}	8 {{{description}}}

12 </dd>{{/description}}	9 {{/description}}

13 {{?properties}}	10 {{?properties}}

14 <h4 id="{{name}}-properties" title="">	11 <table class="innerTable">
	Jeffrey Yasskin 2014/02/07 02:40:03 Nested tables don't look great, although I'm reaso Nested tables don't look great, although I'm reasonably happy to let this through and iterate.
15 Properties of <a href="#property-{{name}}">{{name}}</a>	12 <thead><th colspan="3">Properties</th></thead>

16 </h4>	13 {{#p:properties}}

17 <dd><dl>{{#p:properties}}

18 {{+partials.parameter_full parameter:p parentName:false/}}	14 {{+partials.parameter_full parameter:p parentName:false/}}

19 {{/properties}}</dl></dd>	15 {{/properties}}

	16 </table>

20 {{/properties}}	17 {{/properties}}

21 {{?functions}}	18 {{?functions}}

22 <h4 id="{{name}}-functions" title="">	19 <table class="innerTable">

23 Methods of <a href="#property-{{name}}">{{name}}</a>	20 <thead><th colspan="3">Functions</th></thead>

24 </h4>	21 {{#f:functions}}

25 <dd><dl>{{#f:functions}}

26 {{+partials.function function:f parentName:false/}}	22 {{+partials.function function:f parentName:false/}}

27 {{/}}</dl></dd>

28 {{/functions}}	23 {{/functions}}

29 </div>	24 </table>

30 </div>	25 {{/functions}}

	26 </td>

	27 </tr>

31 {{/property}}	28 {{/property}}

OLD	NEW