chrome/common/extensions/docs/templates/private/api.html - Issue 149673004: Rework API reference pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/private/api.html

Issue 149673004: Rework API reference pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed reviewer comments from CL 121713002 Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/docs/static/sass/_api.scss ('K') | « chrome/common/extensions/docs/static/sass/site.scss ('k') | chrome/common/extensions/docs/templates/private/api_property.html » ('j') | chrome/common/extensions/docs/templates/private/api_property.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {{- This is the shared template for API documentations.	1 {{- This is the shared template for API documentations.

2 - \|api\| The API being documented.	2 - \|api\| The API being documented.

3 - \|intro?\| The intro documentation for the API, if any.	3 - \|intro?\| The intro documentation for the API, if any.

4 - \|samplesForApi\| The API samples.	4 - \|samplesForApi\| The API samples.

5 - \|sidenav\| The sidenav items.	5 - \|sidenav\| The sidenav items.

6 - \|platform\| The platform.	6 - \|platform\| The platform.

7 - \|platformTitle\| The title of the platform ("Extensions" or "Apps").	7 - \|platformTitle\| The title of the platform ("Extensions" or "Apps").

8 -}}	8 -}}

9 {{+content:partials.site	9 {{+content:partials.site

10 platform:platform	10 platform:platform

11 platformTitle:platformTitle	11 platformTitle:platformTitle

12 sidenav:sidenav}}	12 sidenav:sidenav}}

13 {{?api.channelWarning.trunk +partials.warning_trunk/}}	13 {{?api.channelWarning.trunk +partials.warning_trunk/}}

14 {{?api.channelWarning.dev +partials.warning_dev/}}	14 {{?api.channelWarning.dev +partials.warning_dev/}}

15 {{?api.channelWarning.beta +partials.warning_beta/}}	15 {{?api.channelWarning.beta +partials.warning_beta/}}

16 <h1>{{api.title}}</h1>	16 <article>

17 {{?api.deprecated +partials.warning_deprecated item:api/}}	17 <div itemprop="articleBody" class="api">
Jeffrey Yasskin 2014/02/07 02:40:03 Does this need to exist somewhere else? Does this need to exist somewhere else?	Jeffrey Yasskin 2014/02/07 02:40:03 This is an odd use of itemprop: http://developers. This is an odd use of itemprop: http://developers.whatwg.org/microdata.html#names:-the-itemprop-attribute. There's no itemscope to create the item it's a property on. What's it for? Do you need the separate <article> and <div> layers at all? Can they just be a single element?
18 $(table_of_contents)	18 <h1>{{api.title}}</h1>

19 {{+partials.intro_table api:api /}}	19 {{+partials.intro_table api:api /}}

20 {{?intro}}	20 {{?intro}}

21 <section>	21 <section>

22 {{+intro platform:platform platformTitle:platformTitle /}}	22 {{+intro platform:platform platformTitle:platformTitle /}}

23 </section>	23 </section>

24 {{/intro}}	24 {{/intro}}

25 <section>	25 {{+partials.api_summary api:api/}}

26 <h2 id="api-reference-header" title="">{{api.namespace}} reference</h2>	26 <section>

27 {{+partials.api_reference api:api	27 {{+partials.api_reference api:api

28 platform:platform	28 platform:platform

29 platformTitle:platformTitle	29 platformTitle:platformTitle

30 samplesForApi:samplesForApi /}}	30 samplesForApi:samplesForApi /}}

31 </section>	31 </section>

	32 </div>

	33 </article>

32 {{/partials.site}}	34 {{/partials.site}}

OLD	NEW