Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: chrome/common/extensions/docs/static/sass/_api.scss

Issue 149673004: Rework API reference pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed reviewer comments from CL 121713002 Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 .api {
2 color: #333;
Jeffrey Yasskin 2014/02/07 02:40:03 Contrast ratio 12.6:1. I wonder if we should comm
Renato Mangini (chromium) 2014/02/14 00:50:50 Good point. As you noticed, at least for API pages
3 font-size: 14px;
4
5 .api-summary {
Jeffrey Yasskin 2014/02/07 02:40:03 This hasn't been propagated to the compiled css, w
Renato Mangini (chromium) 2014/02/14 00:50:50 You need to compile SASS files. And yes, it will b
6 td, th {
7 padding: 5px 10px;
8 }
9 a {
10 color: inherit;
11 font-weight: normal;
12 }
13 td:hover a, td:hover a * {
Jeffrey Yasskin 2014/02/07 02:40:03 We shouldn't have a UI that requires you to scan y
Renato Mangini (chromium) 2014/02/14 00:50:50 Done. Added a link with the function name and the
14 cursor: pointer;
15 color: $link-color;
16 font-weight: bold;
Jeffrey Yasskin 2014/02/07 02:40:03 We shouldn't change the size of text on hover. It
Renato Mangini (chromium) 2014/02/14 00:50:50 Done.
17 }
18 }
19
20 .api-reference {
21 .description {
22 margin-left: 20px;
23 }
24 table.innerTable {
25 margin: 10px 0;
26 td, th {
27 padding: 5px 10px;
28 border: 1px solid #eee;
29 }
30 th {
31 background: none;
Jeffrey Yasskin 2014/02/07 02:40:03 Please comment which background this cancels.
32 }
33 p {
34 margin: 0;
Jeffrey Yasskin 2014/02/07 02:40:03 Do we have any places where we have 2 paragraphs i
35 }
36 }
37 td, th {
38 border: 1px solid #eee;
39 }
40 th {
41 background: #fafafa;
Jeffrey Yasskin 2014/02/07 02:40:03 Contrast ratio 12.1:1
42 }
43 h2 {
44 background-color: darken($gray-light, 5%);
Jeffrey Yasskin 2014/02/07 02:40:03 Contrast ratio 17.1:1
45 padding: $default-padding;
46 margin-left: $default-padding * -1;
47 margin-right: $default-padding * -1;
48 }
49 h3 {
50 margin-top: rhythm(2);
Jeffrey Yasskin 2014/02/07 02:40:03 Is there a good way to search for the definitions
Renato Mangini (chromium) 2014/02/14 00:50:50 Done.
51 }
52 }
53 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698