Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1496703005: Prevent infinite looping in CPDF_Parser::LoadAllCrossRefV5(). (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Prevent infinite looping in CPDF_Parser::LoadAllCrossRefV5(). BUG=pdfium:298 R=weili@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/93181f9a20db7ac706bb9405750303db93762a5b

Patch Set 1 #

Patch Set 2 : LoadLinearizedAllCrossRefV5 as well #

Patch Set 3 : Add test #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -22 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 3 5 chunks +26 lines, -13 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A + testing/resources/bug_298.in View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
A testing/resources/bug_298.pdf View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
5 years ago (2015-12-04 03:06:51 UTC) #2
Wei Li
LGTM
5 years ago (2015-12-04 18:23:28 UTC) #3
Lei Zhang
I noticed LoadLinearizedAllCrossRefV5() has the same pattern, so I applied the same fix there as ...
5 years ago (2015-12-04 21:13:38 UTC) #4
Lei Zhang
I'll also see if I can write a test case...
5 years ago (2015-12-04 21:14:00 UTC) #5
Lei Zhang
On 2015/12/04 21:14:00, Lei Zhang wrote: > I'll also see if I can write a ...
5 years ago (2015-12-05 07:59:56 UTC) #6
Wei Li
On 2015/12/05 07:59:56, Lei Zhang wrote: > On 2015/12/04 21:14:00, Lei Zhang wrote: > > ...
5 years ago (2015-12-07 22:10:27 UTC) #7
Lei Zhang
5 years ago (2015-12-10 04:15:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
93181f9a20db7ac706bb9405750303db93762a5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698