third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp - Issue 1496683002: Avoid rounding down viewport dimensions in Media Queries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp

Issue 1496683002: Avoid rounding down viewport dimensions in Media Queries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved to double Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/media/mq-width-on-zoom-expected.txt ('k') | third_party/WebKit/Source/core/css/MediaQueryEvaluatorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp

diff --git a/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp b/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp

index b2c7a684f433a72935a52ae22421604a84b378eb..161fece95aab49a03b1256202ad038728043f26f 100644

--- a/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp

+++ b/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp

@@ -393,7 +393,7 @@ static bool deviceWidthMediaFeatureEval(const MediaQueryExpValue& value, MediaFe

static bool heightMediaFeatureEval(const MediaQueryExpValue& value, MediaFeaturePrefix op, const MediaValues& mediaValues)

{

- int height = mediaValues.viewportHeight();

+ double height = mediaValues.viewportHeight();

if (value.isValid())

return computeLengthAndCompare(value, op, mediaValues, height);

@@ -402,7 +402,7 @@ static bool heightMediaFeatureEval(const MediaQueryExpValue& value, MediaFeature

static bool widthMediaFeatureEval(const MediaQueryExpValue& value, MediaFeaturePrefix op, const MediaValues& mediaValues)

{

- int width = mediaValues.viewportWidth();

+ double width = mediaValues.viewportWidth();

if (value.isValid())

return computeLengthAndCompare(value, op, mediaValues, width);