Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1496673002: Reland of Add tryserver.infra to Rietveld. (Closed)

Created:
5 years ago by tandrii(chromium)
Modified:
5 years ago
CC:
chromium-reviews, rmistry+cc_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Reland of Add tryserver.infra to Rietveld. (patchset #1 id:1 of https://codereview.chromium.org/1294023007/ ) Reason for revert: and now that Rietveld schedules through buildbucket, this will work. Original issue's description: > Revert of Add tryserver.infra to Rietveld. (patchset #1 id:1 of https://codereview.chromium.org/1283133004/ ) > > Reason for revert: > Because we don't have and can't easily have TryJobRietveld inside our master definition. So, let's not confuse people - scheduling from Rietveld won't work. > > See http://crbug.com/403494#42 for more. > > Original issue's description: > > Add tryserver.infra to Rietveld. > > > > BUG=403494 > > > > Committed: https://chromium.googlesource.com/infra/infra/+/1f556d3a26310188ebd8e4b36282b0970e617de9 > > TBR=jrobbins@chromium.org,akuegel@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=403494 > > Committed: https://chromium.googlesource.com/infra/infra/+/8ee5e0d08274d7862f49403b4f80c43592c013d9 TBR=akuegel@chromium.org,jrobbins@chromium.org,jrobbins@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=403494, 564053 Committed: https://chromium.googlesource.com/infra/infra/+/3a6aa48da3dc3f01190c81075cc6df1cfd275ed0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M appengine/chromium_rietveld/codereview/models_chromium.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tandrii(chromium)
Created Reland of Add tryserver.infra to Rietveld.
5 years ago (2015-12-02 20:03:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496673002/1
5 years ago (2015-12-02 20:04:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/3a6aa48da3dc3f01190c81075cc6df1cfd275ed0
5 years ago (2015-12-02 20:04:38 UTC) #7
tandrii(chromium)
+andybons@ as this is Rietveld patch.
5 years ago (2015-12-02 20:06:45 UTC) #9
Bons
5 years ago (2015-12-02 20:07:44 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698