Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1496663002: EDK: Make mojo::platform::TaskRunner's PostTask() take an std::function<void()>. (Closed)

Created:
5 years ago by viettrungluu
Modified:
5 years ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Make mojo::platform::TaskRunner's PostTask() take an std::function<void()>. * Keep the version that takes a base::Closure around for now. * Propagate this to TestIOThread's PostTask()/PostTaskAndWait(). * Convert many things (esp. in tests) to use lambdas instead of base::Bind. The following problems remain (preventing the eradication of base::Bind, base::Callback, etc.): * You can't (in C++11) move-capture, so instances requiring capture of move-only types (mostly) remain using base::Bind. * We're still directly using base::MessageLoop in various places. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2d07e279a9c613e533dda0dbf838346fc4f77ae8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -289 lines) Patch
M mojo/edk/base_edk/message_loop_test_helper.cc View 4 chunks +16 lines, -30 lines 0 comments Download
M mojo/edk/base_edk/platform_task_runner_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/base_edk/platform_task_runner_impl.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 2 chunks +12 lines, -17 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 5 chunks +21 lines, -16 lines 0 comments Download
M mojo/edk/platform/task_runner.h View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/edk/system/channel.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/channel_endpoint_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M mojo/edk/system/channel_manager.h View 1 chunk +0 lines, -7 lines 0 comments Download
M mojo/edk/system/channel_manager.cc View 4 chunks +22 lines, -36 lines 0 comments Download
M mojo/edk/system/channel_test_base.h View 2 chunks +0 lines, -7 lines 0 comments Download
M mojo/edk/system/channel_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/channel_unittest.cc View 7 chunks +14 lines, -16 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M mojo/edk/system/endpoint_relayer_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 5 chunks +14 lines, -16 lines 0 comments Download
M mojo/edk/system/message_pipe_perftest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/system/message_pipe_test_utils.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 21 chunks +28 lines, -53 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 8 chunks +16 lines, -24 lines 0 comments Download
M mojo/edk/system/slave_connection_manager.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M mojo/edk/system/test/test_io_thread.h View 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/edk/system/test/test_io_thread.cc View 3 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
5 years ago (2015-12-02 18:54:43 UTC) #1
vardhan
lgtm
5 years ago (2015-12-02 20:37:59 UTC) #2
viettrungluu
5 years ago (2015-12-02 20:47:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2d07e279a9c613e533dda0dbf838346fc4f77ae8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698