Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1496633002:
Disable flakey test (Closed)
DescriptionDisable flakey test
Will sort out flake separately.
BUG=559412
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org
Committed: https://crrev.com/b3b549d18b0086915a94dcd7f40984c6d98d3adf
Cr-Commit-Position: refs/heads/master@{#362757}
Patch Set 1 #
Messages
Total messages: 13 (4 generated)
The CQ bit was checked by sky@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496633002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable flakey test Will sort out flake separately. BUG=559412 TEST=none R=jam@chromium.org TBR=jam@chromium.org ========== to ========== Disable flakey test Will sort out flake separately. BUG=559412 TEST=none R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/b3b549d18b0086915a94dcd7f40984c6d98d3adf Cr-Commit-Position: refs/heads/master@{#362757} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b3b549d18b0086915a94dcd7f40984c6d98d3adf Cr-Commit-Position: refs/heads/master@{#362757}
Message was sent while issue was closed.
scheib@chromium.org changed reviewers: + scheib@chromium.org
Message was sent while issue was closed.
Please be a tad more specific, e.g. test name in change title/description in future patches.
Message was sent while issue was closed.
Looks like this broke "Linux Tests"'s mojo_apptests? http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests Log: Running mojo:mash_wm_apptests... DEBUG:Command: /mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/mojo_runner --use-x11-test-config --override-use-gl-with-osmesa-for-tests --gtest_list_tests mojo:mash_wm_apptests DEBUG:Tests for mojo:mash_wm_apptests: ['WindowManagerAppTest.DISABLED_OpenWindow'] [ FAILED ] mojo:mash_wm_apptests Not sure how that's possible? Do they not handle the "DISABLED" prefix?
Message was sent while issue was closed.
Description was changed from ========== Disable flakey test Will sort out flake separately. BUG=559412 TEST=none R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/b3b549d18b0086915a94dcd7f40984c6d98d3adf Cr-Commit-Position: refs/heads/master@{#362757} ========== to ========== Disable flakey test Will sort out flake separately. BUG=559412 TEST=none R=jam@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/b3b549d18b0086915a94dcd7f40984c6d98d3adf Cr-Commit-Position: refs/heads/master@{#362757} ==========
Message was sent while issue was closed.
On 2015/12/02 20:37:01, gab wrote: > Looks like this broke "Linux Tests"'s mojo_apptests? > > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests > > Log: > > Running mojo:mash_wm_apptests... > DEBUG:Command: > /mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/mojo_runner > --use-x11-test-config --override-use-gl-with-osmesa-for-tests --gtest_list_tests > mojo:mash_wm_apptests > DEBUG:Tests for mojo:mash_wm_apptests: > ['WindowManagerAppTest.DISABLED_OpenWindow'] > [ FAILED ] mojo:mash_wm_apptests > > Not sure how that's possible? Do they not handle the "DISABLED" prefix? That's what I thought, but looks like DISABLED_ is correctly detected. But the script fails if no test ran at all. Fix up for review at https://codereview.chromium.org/1499463002/
Message was sent while issue was closed.
On 2015/12/02 20:39:30, sadrul wrote: > On 2015/12/02 20:37:01, gab wrote: > > Looks like this broke "Linux Tests"'s mojo_apptests? > > > > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests > > > > Log: > > > > Running mojo:mash_wm_apptests... > > DEBUG:Command: > > /mnt/data/b/build/slave/Linux_Tests/build/src/out/Release/mojo_runner > > --use-x11-test-config --override-use-gl-with-osmesa-for-tests > --gtest_list_tests > > mojo:mash_wm_apptests > > DEBUG:Tests for mojo:mash_wm_apptests: > > ['WindowManagerAppTest.DISABLED_OpenWindow'] > > [ FAILED ] mojo:mash_wm_apptests > > > > Not sure how that's possible? Do they not handle the "DISABLED" prefix? > > That's what I thought, but looks like DISABLED_ is correctly detected. But the > script fails if no test ran at all. Fix up for review at > https://codereview.chromium.org/1499463002/ I was worried about that, but assumed the cq would catch it.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1499473002/ by sky@chromium.org. The reason for reverting is: Calls failure in script.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
