Issue 1496603002: Fix NSME in `type_annotate_public_apis` (#151).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1496603002: Fix NSME in `type_annotate_public_apis` (#151). (Closed)

Created:
5 years ago by pquitslund

Modified:
5 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/linter.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix NSME in `type_annotate_public_apis` (#151). Improves getter/setter handling. Fixes #151. R=scheglov@google.com Committed: https://github.com/dart-lang/linter/commit/978780db714597558c754c53b9bf7b4bedbef4d1

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -27 lines)			Patch
	M	lib/src/rules/type_annotate_public_apis.dart	View		3 chunks	+27 lines, -27 lines	0 comments	Download
	M	test/rules/type_annotate_public_apis.dart	View		2 chunks	+16 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

pquitslund

5 years ago (2015-12-02 18:21:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
978780db714597558c754c53b9bf7b4bedbef4d1 (presubmit successful).