Ensure Sync access token is revoked when user is signed out.

components/browser_sync/browser/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/browser_sync/browser/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <vector>
 
@@ skipping 747 matching lines @@
   tracked_objects::ScopedTracker tracking_profile(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "422460 ProfileSyncService::OnRefreshTokenAvailable"));
 
   if (account_id == signin_->GetAccountIdToUse())
     OnRefreshTokensLoaded();
 }
 
 void ProfileSyncService::OnRefreshTokenRevoked(
     const std::string& account_id) {
-  if (account_id == signin_->GetAccountIdToUse()) {
+  if (account_id == signin_->GetAccountIdToUse() ||
+      !signin_->GetOriginal()->IsAuthenticated()) {

[Nicolas Zea, 2015/12/02 18:57:35]

Is this the right place to fix this? Why isn't the first condition sufficient?
It seems like the refresh token should be revoked when you switch accounts,
right?

[bzanotti, 2015/12/02 22:21:46]

Please note that I'm not super familiar with sync code, I was just trying to
reintroduce the same logic that was removed in http://crrev.com/1354053004
without reintroducing the bug.

Maybe this is not the best place to fix this, but note that due to how signout
works, this notification is received before the OnGoogleSignOut notification
(but SigninManager will already return false to IsAuthenticated).

Maybe the access_token should simply be cleared on signout (I have no idea why
this isn't the case, but I can observe this on iOS). If you have more
information/context on this, I'm very interested.

[Nicolas Zea, 2015/12/02 22:27:54]

Yeah, I think that OnGoogleSignedOut should also be clearing the access_token_
(and calling the UpdateAuthErrorState). That seems a more natural fit for this
logic, and I agree it seems wrong that wasn't happening before.

     access_token_.clear();
     UpdateAuthErrorState(
         GoogleServiceAuthError(GoogleServiceAuthError::REQUEST_CANCELED));
   }
 }
 
 void ProfileSyncService::OnRefreshTokensLoaded() {
   // This notification gets fired when OAuth2TokenService loads the tokens
   // from storage.
   // Initialize the backend if sync is enabled. If the sync token was
@@ skipping 1924 matching lines @@
 }
 
 std::string ProfileSyncService::unrecoverable_error_message() const {
   return unrecoverable_error_message_;
 }
 
 tracked_objects::Location ProfileSyncService::unrecoverable_error_location()
     const {
   return unrecoverable_error_location_;
 }