Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1008)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1496533003: Implement a simple version of SelectorQuery. (Closed)

Created:
5 years ago by esprehn
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement a simple version of SelectorQuery. BUG=492482

Patch Set 1 : No bloom filter #

Patch Set 2 : With bloom filter. #

Patch Set 3 : Different approach using classes. #

Patch Set 4 : Refactor into separate files. #

Patch Set 5 : Revert change to SelectorFilter.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -534 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.h View 1 2 1 chunk +11 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.h View 1 2 3 1 chunk +4 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 1 2 3 1 chunk +36 lines, -474 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorAnyMatcher.h View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorAnyMatcher.cpp View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorCheckerMatcher.h View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorCheckerMatcher.cpp View 1 2 3 1 chunk +115 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorClassMatcher.h View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorClassMatcher.cpp View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorIdMatcher.h View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorIdMatcher.cpp View 1 2 3 1 chunk +56 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorMatcher.h View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorMatcher.cpp View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorTagMatcher.h View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/query/SelectorTagMatcher.cpp View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496533003/1
5 years ago (2015-12-03 06:36:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496533003/20001
5 years ago (2015-12-03 07:22:15 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/149487)
5 years ago (2015-12-03 08:12:49 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496533003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496533003/80001
5 years ago (2015-12-10 04:16:30 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 04:21:34 UTC) #10 
Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

Powered by Google App Engine
This is Rietveld 408576698