Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 149653004: Revert 248827 "android: Migrate old content readback to use asyn..." (Closed)

Created:
6 years, 10 months ago by pasko
Modified:
6 years, 10 months ago
Reviewers:
powei
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 248827 "android: Migrate old content readback to use asyn..." Breaks android ToT, and the pairing change downstream is not ready yet. > android: Migrate old content readback to use async readback (and delegated renderer) > > This patch removes the use of a helper context for content readback. Instead, > we use the async readback API. > > This patch is also setting delegated renderer as the default for android. > > android= https://chrome-internal-review.googlesource.com/#/c/152377/ > > BUG=326363 > TBR=sievers > NOTRY=true > > Review URL: https://codereview.chromium.org/143803004 TBR=powei@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -195 lines) Patch
M trunk/src/cc/resources/ui_resource_bitmap.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/cc/resources/ui_resource_bitmap.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M trunk/src/cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M trunk/src/content/browser/android/content_startup_flags.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/content/browser/android/content_view_core_impl.h View 1 chunk +2 lines, -4 lines 0 comments Download
M trunk/src/content/browser/android/content_view_core_impl.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M trunk/src/content/browser/renderer_host/compositor_impl_android.h View 4 chunks +17 lines, -12 lines 0 comments Download
M trunk/src/content/browser/renderer_host/compositor_impl_android.cc View 4 chunks +120 lines, -84 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_android.h View 2 chunks +6 lines, -5 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_android.cc View 13 chunks +46 lines, -40 lines 0 comments Download
M trunk/src/content/public/browser/android/compositor.h View 2 chunks +29 lines, -12 lines 0 comments Download
M trunk/src/content/public/browser/android/content_view_core.h View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pasko
6 years, 10 months ago (2014-02-05 13:20:43 UTC) #1
pasko
6 years, 10 months ago (2014-02-05 13:21:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r248976.

Powered by Google App Engine
This is Rietveld 408576698