[runtime] [proxy] removing JSFunctionProxy and related code.

[runtime] [proxy] removing JSFunctionProxy and related code.

BUG=v8:1543
LOG=N

Committed: https://crrev.com/747f455b074751040cc8ac0ede83f3880ccc488b
Cr-Commit-Position: refs/heads/master@{#32616}

[Camillo Bruni, 2015-12-02 12:46:50]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 12:47:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/20001

[commit-bot: I haz the power, 2015-12-02 12:48:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 12:48:08]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/12621)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8403)

[Camillo Bruni, 2015-12-02 13:03:47]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 13:04:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/40001

[commit-bot: I haz the power, 2015-12-02 13:17:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 13:17:11]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Camillo Bruni, 2015-12-02 14:54:18]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 14:54:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/60001

[commit-bot: I haz the power, 2015-12-02 15:16:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 15:16:51]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)

[Camillo Bruni, 2015-12-02 17:17:48]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-02 17:17:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/80001

[Camillo Bruni, 2015-12-02 17:35:47]

cbruni@chromium.org changed reviewers:
+ verwaest@chromium.org

[Camillo Bruni, 2015-12-02 17:36:00]

PTAL

[commit-bot: I haz the power, 2015-12-02 17:40:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-02 17:40:02]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2015-12-02 17:50:51]

Description was changed from

==========
[runtime] [proxy] removing JSFunctionProxy and related code.

BUG=c8:1543
LOG=N
==========

to

==========
[runtime] [proxy] removing JSFunctionProxy and related code.

BUG=v8:1543
LOG=N
==========

[Toon Verwaest, 2015-12-03 11:48:42]

https://codereview.chromium.org/1496503002/diff/80001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/arm/builtins-arm.cc...
src/arm/builtins-arm.cc:1700: __ b(&non_smi);
you probably wanted to remove this b(&non_smi), loop otherwise ... :)

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/arm/lith...
File src/crankshaft/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/arm/lith...
src/crankshaft/arm/lithium-codegen-arm.cc:5554: DeoptimizeIf(le, instr,
Deoptimizer::kWrongInstanceType);
le->eq

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/arm64/li...
File src/crankshaft/arm64/lithium-codegen-arm64.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/arm64/li...
src/crankshaft/arm64/lithium-codegen-arm64.cc:2831: DeoptimizeIf(le, instr,
Deoptimizer::kNotAJavaScriptObject);
le->eq

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/ia32/lit...
File src/crankshaft/ia32/lithium-codegen-ia32.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/ia32/lit...
src/crankshaft/ia32/lithium-codegen-ia32.cc:5430: DeoptimizeIf(below_equal,
instr, Deoptimizer::kWrongInstanceType);
equal

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/mips/lit...
File src/crankshaft/mips/lithium-codegen-mips.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/mips/lit...
src/crankshaft/mips/lithium-codegen-mips.cc:5596: DeoptimizeIf(le, instr,
Deoptimizer::kNotAJavaScriptObject, a1,
eq

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/mips64/l...
File src/crankshaft/mips64/lithium-codegen-mips64.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/mips64/l...
src/crankshaft/mips64/lithium-codegen-mips64.cc:5786: DeoptimizeIf(le, instr,
Deoptimizer::kNotAJavaScriptObject, a1,
eq

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/ppc/lith...
File src/crankshaft/ppc/lithium-codegen-ppc.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/ppc/lith...
src/crankshaft/ppc/lithium-codegen-ppc.cc:5834: DeoptimizeIf(le, instr,
Deoptimizer::kWrongInstanceType);
eq

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/x64/lith...
File src/crankshaft/x64/lithium-codegen-x64.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/x64/lith...
src/crankshaft/x64/lithium-codegen-x64.cc:5628: DeoptimizeIf(below_equal, instr,
Deoptimizer::kWrongInstanceType);
equal

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/x87/lith...
File src/crankshaft/x87/lithium-codegen-x87.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/x87/lith...
src/crankshaft/x87/lithium-codegen-x87.cc:5990: DeoptimizeIf(below_equal, instr,
Deoptimizer::kWrongInstanceType);
equal

https://codereview.chromium.org/1496503002/diff/80001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/ia32/builtins-ia32....
src/ia32/builtins-ia32.cc:1560: __ jmp(&non_smi);
probably want to drop this jmp

https://codereview.chromium.org/1496503002/diff/80001/src/js/v8natives.js
File src/js/v8natives.js (right):

https://codereview.chromium.org/1496503002/diff/80001/src/js/v8natives.js#new...
src/js/v8natives.js:1545: //TODO(cbruni): resolve func to a non-proxy function
for printing
The spec for Function.prototype.toString says only builtin functions and objects
with [[ECMAScriptCode]] are handled; so only real functions, not proxies. In all
other cases we throw a type error. Hence this comment isn't necessary.
IS_FUNCTION will return true for generators and jsfunctions (including builtins)
which is what we want.

https://codereview.chromium.org/1496503002/diff/80001/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/mips/builtins-mips....
src/mips/builtins-mips.cc:1709: __ Branch(&non_smi);
drop the branch

https://codereview.chromium.org/1496503002/diff/80001/src/mips64/builtins-mip...
File src/mips64/builtins-mips64.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/mips64/builtins-mip...
src/mips64/builtins-mips64.cc:1704: __ Branch(&non_smi);
drop the branch

https://codereview.chromium.org/1496503002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/objects.cc#newcode4758
src/objects.cc:4758: // TODO(cbruni): deal with [[Call]] here?
DCHECK(target->map()->is_callable());
This is guaranteed by the context. Otherwise I don't get your comment :)

https://codereview.chromium.org/1496503002/diff/80001/src/ppc/builtins-ppc.cc
File src/ppc/builtins-ppc.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/ppc/builtins-ppc.cc...
src/ppc/builtins-ppc.cc:1713: __ b(&non_smi);
drop branch (Implementy?)

https://codereview.chromium.org/1496503002/diff/80001/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/1496503002/diff/80001/src/runtime/runtime.h#n...
src/runtime/runtime.h:546: F(GetHandler, 1, 1)               \
drop \ at end

https://codereview.chromium.org/1496503002/diff/80001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/x64/builtins-x64.cc...
src/x64/builtins-x64.cc:1757: __ jmp(&non_smi);
drop branch

https://codereview.chromium.org/1496503002/diff/80001/src/x87/builtins-x87.cc
File src/x87/builtins-x87.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/x87/builtins-x87.cc...
src/x87/builtins-x87.cc:1560: __ jmp(&non_smi);
drop branch

[Camillo Bruni, 2015-12-03 12:18:26]

PTAL,
as discussed offline, le -> eq change is not necessary.
addressed all other comments.

https://codereview.chromium.org/1496503002/diff/80001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/arm/builtins-arm.cc...
src/arm/builtins-arm.cc:1700: __ b(&non_smi);
On 2015/12/03 at 11:48:41, Toon Verwaest wrote:
> you probably wanted to remove this b(&non_smi), loop otherwise ... :)

done

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/arm/lith...
File src/crankshaft/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/crankshaft/arm/lith...
src/crankshaft/arm/lithium-codegen-arm.cc:5554: DeoptimizeIf(le, instr,
Deoptimizer::kWrongInstanceType);
On 2015/12/03 at 11:48:41, Toon Verwaest wrote:
> le->eq

we check for all types so we need the less-equals. Same for all other platforms
below.

https://codereview.chromium.org/1496503002/diff/80001/src/ia32/builtins-ia32.cc
File src/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/ia32/builtins-ia32....
src/ia32/builtins-ia32.cc:1560: __ jmp(&non_smi);
On 2015/12/03 at 11:48:42, Toon Verwaest wrote:
> probably want to drop this jmp

done.

https://codereview.chromium.org/1496503002/diff/80001/src/js/v8natives.js
File src/js/v8natives.js (right):

https://codereview.chromium.org/1496503002/diff/80001/src/js/v8natives.js#new...
src/js/v8natives.js:1545: //TODO(cbruni): resolve func to a non-proxy function
for printing
On 2015/12/03 at 11:48:42, Toon Verwaest wrote:
> The spec for Function.prototype.toString says only builtin functions and
objects with [[ECMAScriptCode]] are handled; so only real functions, not
proxies. In all other cases we throw a type error. Hence this comment isn't
necessary. IS_FUNCTION will return true for generators and jsfunctions
(including builtins) which is what we want.

removed.

https://codereview.chromium.org/1496503002/diff/80001/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/mips/builtins-mips....
src/mips/builtins-mips.cc:1709: __ Branch(&non_smi);
On 2015/12/03 at 11:48:42, Toon Verwaest wrote:
> drop the branch

done

https://codereview.chromium.org/1496503002/diff/80001/src/mips64/builtins-mip...
File src/mips64/builtins-mips64.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/mips64/builtins-mip...
src/mips64/builtins-mips64.cc:1704: __ Branch(&non_smi);
On 2015/12/03 at 11:48:42, Toon Verwaest wrote:
> drop the branch

done

https://codereview.chromium.org/1496503002/diff/80001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/objects.cc#newcode4758
src/objects.cc:4758: // TODO(cbruni): deal with [[Call]] here?
On 2015/12/03 at 11:48:42, Toon Verwaest wrote:
> DCHECK(target->map()->is_callable());
> This is guaranteed by the context. Otherwise I don't get your comment :)

indeed doesn't matter, removed comment.

https://codereview.chromium.org/1496503002/diff/80001/src/ppc/builtins-ppc.cc
File src/ppc/builtins-ppc.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/ppc/builtins-ppc.cc...
src/ppc/builtins-ppc.cc:1713: __ b(&non_smi);
On 2015/12/03 at 11:48:42, Toon Verwaest wrote:
> drop branch (Implementy?)

done

https://codereview.chromium.org/1496503002/diff/80001/src/runtime/runtime.h
File src/runtime/runtime.h (right):

https://codereview.chromium.org/1496503002/diff/80001/src/runtime/runtime.h#n...
src/runtime/runtime.h:546: F(GetHandler, 1, 1)               \
On 2015/12/03 at 11:48:42, Toon Verwaest wrote:
> drop \ at end

done

https://codereview.chromium.org/1496503002/diff/80001/src/x64/builtins-x64.cc
File src/x64/builtins-x64.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/x64/builtins-x64.cc...
src/x64/builtins-x64.cc:1757: __ jmp(&non_smi);
On 2015/12/03 at 11:48:42, Toon Verwaest wrote:
> drop branch

done

https://codereview.chromium.org/1496503002/diff/80001/src/x87/builtins-x87.cc
File src/x87/builtins-x87.cc (right):

https://codereview.chromium.org/1496503002/diff/80001/src/x87/builtins-x87.cc...
src/x87/builtins-x87.cc:1560: __ jmp(&non_smi);
On 2015/12/03 at 11:48:42, Toon Verwaest wrote:
> drop branch

done

[Toon Verwaest, 2015-12-03 14:32:20]

lgtm

[Camillo Bruni, 2015-12-03 14:59:07]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-12-03 14:59:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/100001

[commit-bot: I haz the power, 2015-12-03 15:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 15:01:03]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[Camillo Bruni, 2015-12-03 16:06:17]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 16:06:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/120001

[Camillo Bruni, 2015-12-03 16:14:34]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 16:14:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/140001

[commit-bot: I haz the power, 2015-12-03 17:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 17:41:06]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2015-12-03 18:23:45]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-12-03 18:23:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1496503002/#ps140001
(title: "fixing wrong range check under x64")

[commit-bot: I haz the power, 2015-12-03 18:23:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/140001

[commit-bot: I haz the power, 2015-12-03 19:39:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 19:39:33]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8516)

[Camillo Bruni, 2015-12-04 08:44:11]

cbruni@chromium.org changed reviewers:
+ hpayer@chromium.org, mstarzinger@chromium.org

[Camillo Bruni, 2015-12-04 08:44:12]

hpayer please heap.
mstarzinger please compile.

[Hannes Payer (out of office), 2015-12-04 08:48:16]

heap lgtm

[Michael Starzinger, 2015-12-04 12:23:07]

LGTM on "compiler", didn't look at the rest.

[Camillo Bruni, 2015-12-04 12:40:22]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-12-04 12:40:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/140001

[commit-bot: I haz the power, 2015-12-04 12:42:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 12:42:19]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8542)

[Camillo Bruni, 2015-12-04 13:05:50]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-12-04 13:05:51]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
verwaest@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1496503002/#ps160001
(title: "merging with master")

[commit-bot: I haz the power, 2015-12-04 13:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/160001

[commit-bot: I haz the power, 2015-12-04 13:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 13:11:26]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)

[Camillo Bruni, 2015-12-04 13:21:22]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-12-04 13:21:23]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org,
verwaest@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1496503002/#ps180001
(title: "fixing merge artifacts")

[commit-bot: I haz the power, 2015-12-04 13:21:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496503002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496503002/180001

[commit-bot: I haz the power, 2015-12-04 13:49:15]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-12-04 13:49:30]

Description was changed from

==========
[runtime] [proxy] removing JSFunctionProxy and related code.

BUG=v8:1543
LOG=N
==========

to

==========
[runtime] [proxy] removing JSFunctionProxy and related code.

BUG=v8:1543
LOG=N

Committed: https://crrev.com/747f455b074751040cc8ac0ede83f3880ccc488b
Cr-Commit-Position: refs/heads/master@{#32616}
==========

[commit-bot: I haz the power, 2015-12-04 13:49:31]

Patchset 10 (id:??) landed as
https://crrev.com/747f455b074751040cc8ac0ede83f3880ccc488b
Cr-Commit-Position: refs/heads/master@{#32616}