Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1496493004: Revert of Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor. (Closed)

Created:
5 years ago by tapted
Modified:
5 years ago
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, davemoore+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jdonnelly+autofillwatch_chromium.org, Matt Giuca, oshima+watch_chromium.org, rouslan+autofill_chromium.org, tapted, tfarina, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor. (patchset #4 id:60001 of https://codereview.chromium.org/1417353006/ ) Reason for revert: Suspected for persistent failures on ios_net_unittests - RoundTripTestCookieStore/CookieStoreTest/0.TestNonDottedAndTLD - CookieStoreIOS/CookieStoreTest/0.TestNonDottedAndTLD Failing since https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/32876 Errors like ../../net/cookies/cookie_store_unittest.h:536: Failure Value of: this->SetCookie(cs.get(), url, "a=1; domain=com") Actual: false Expected: true (It's a tricky one! Sorry if this is not it) Original issue's description: > Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor. > > Also ports remaining tests using raw SWPs to use SWPOwner. > > BUG=450228 > > Committed: https://crrev.com/fc939726c283e34112d9bc845a39460410fe9cd9 > Cr-Commit-Position: refs/heads/master@{#362805} TBR=phajdan.jr@chromium.org,jam@chromium.org,brettw@chromium.org,tommycli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450228 Committed: https://crrev.com/d7365d9aaa55e88d9ecca49eb2158b62d1190f09 Cr-Commit-Position: refs/heads/master@{#362890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -68 lines) Patch
M base/sequence_checker_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M base/test/launcher/test_launcher.cc View 1 chunk +4 lines, -1 line 0 comments Download
M base/test/sequenced_worker_pool_owner.h View 3 chunks +0 lines, -8 lines 0 comments Download
M base/test/sequenced_worker_pool_owner.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M base/threading/sequenced_task_runner_handle_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 5 chunks +28 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/extensions/external_cache_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 5 chunks +22 lines, -16 lines 0 comments Download
M chrome/browser/ui/app_list/search/history_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/test_autofill_driver.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/component_updater/component_updater_service_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/rlz/rlz_tracker_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M components/update_client/update_client_unittest.cc View 13 chunks +27 lines, -0 lines 0 comments Download
M content/browser/media/webrtc_identity_store_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/net/quota_policy_cookie_store_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/base/file_stream_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_simple_job_unittest.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M ui/app_list/search/history_data_store_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Created Revert of Tests: Simplify SequencedWorkerPoolOwner, call Shutdown on destructor.
5 years ago (2015-12-03 03:37:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496493004/1
5 years ago (2015-12-03 03:37:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 03:39:10 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d7365d9aaa55e88d9ecca49eb2158b62d1190f09 Cr-Commit-Position: refs/heads/master@{#362890}
5 years ago (2015-12-03 03:39:50 UTC) #6
tapted
5 years ago (2015-12-03 04:40:38 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1500503002/ by tapted@chromium.org.

The reason for reverting is: Relanding, no recovery in

https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/bu....

Powered by Google App Engine
This is Rietveld 408576698