Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1496453002: Ship promise rejection events (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
philipj_slow
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : updates #

Messages

Total messages: 7 (2 generated)
philipj_slow
lgtm
5 years ago (2015-12-02 12:54:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496453002/20001
5 years ago (2015-12-02 12:54:41 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 13:47:07 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/98bd85306f3a170fa465c3f5a754ac2519a36be1 Cr-Commit-Position: refs/heads/master@{#362695}
5 years ago (2015-12-02 13:48:08 UTC) #6
Khushal
5 years ago (2015-12-03 03:18:18 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1498703002/ by khushalsagar@chromium.org.

The reason for reverting is: This is breaking SystemWebViewShellLayoutTests on
Android Webview L. See crbug/564765..

Powered by Google App Engine
This is Rietveld 408576698