Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149643010: Cleanup: Move kChromeUIScheme constant into content namespace. (Closed)

Created:
6 years, 10 months ago by tfarina
Modified:
6 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, skanuj+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, ajwong+watch_chromium.org, markusheintz_, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, gavinp+disk_chromium.org, jam, dominich, marja+watch_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, haitaol+watch_chromium.org, jfweitz+watch_chromium.org, Jered, maniscalco+watch_chromium.org, tfarina, donnd+watch_chromium.org, joi+watch-content_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, James Su
Visibility:
Public.

Description

Cleanup: Move kChromeUIScheme constant into content namespace. BUG=None TEST=None, no functional changes TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -117 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M apps/shell/browser/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_view_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_contents_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/search.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions2/sessions_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/translate/translate_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_toolbar_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/origin_chip.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/origin_chip_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/url_fixer_upper.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/content_settings_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/content_settings_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/user_script_slave.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/bookmarks_file_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_url_handler_impl.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/view_blob_internals_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/view_http_cache_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/site_instance_impl_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/savable_url_schemes.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/url_schemes.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/url_data_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/web_ui_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/permissions_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/common/url_pattern.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
TBRing...
6 years, 10 months ago (2014-02-10 22:16:35 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 10 months ago (2014-02-10 22:16:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/149643010/1
6 years, 10 months ago (2014-02-10 22:18:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/149643010/1
6 years, 10 months ago (2014-02-10 22:56:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/149643010/1
6 years, 10 months ago (2014-02-10 23:51:31 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 00:17:35 UTC) #6
Message was sent while issue was closed. 
Change committed as 250244

Powered by Google App Engine
This is Rietveld 408576698