Source/core/fetch/CrossOriginAccessControl.h - Issue 149643003: Improve handling of CORS redirects for some resource loads.

Side by Side Diff: Source/core/fetch/CrossOriginAccessControl.h

Issue 149643003: Improve handling of CORS redirects for some resource loads. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Track source origin via ResourceLoaderOptions.securityOrigin Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/security/script-crossorigin-redirect-no-cors-expected.txt ('k') | Source/core/fetch/CrossOriginAccessControl.cpp » ('j') | Source/core/fetch/ResourceFetcher.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.	2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 bool isOnAccessControlSimpleRequestMethodWhitelist(const String&);	49 bool isOnAccessControlSimpleRequestMethodWhitelist(const String&);

50 bool isOnAccessControlSimpleRequestHeaderWhitelist(const AtomicString& name, con st AtomicString& value);	50 bool isOnAccessControlSimpleRequestHeaderWhitelist(const AtomicString& name, con st AtomicString& value);

51 bool isOnAccessControlResponseHeaderWhitelist(const String&);	51 bool isOnAccessControlResponseHeaderWhitelist(const String&);

52	52

53 void updateRequestForAccessControl(ResourceRequest&, SecurityOrigin*, StoredCred entials);	53 void updateRequestForAccessControl(ResourceRequest&, SecurityOrigin*, StoredCred entials);

54 ResourceRequest createAccessControlPreflightRequest(const ResourceRequest&, Secu rityOrigin*);	54 ResourceRequest createAccessControlPreflightRequest(const ResourceRequest&, Secu rityOrigin*);

55	55

56 bool passesAccessControlCheck(const ResourceResponse&, StoredCredentials, Securi tyOrigin*, String& errorDescription);	56 bool passesAccessControlCheck(const ResourceResponse&, StoredCredentials, Securi tyOrigin*, String& errorDescription);

57 bool passesPreflightStatusCheck(const ResourceResponse&, String& errorDescriptio n);	57 bool passesPreflightStatusCheck(const ResourceResponse&, String& errorDescriptio n);

58 void parseAccessControlExposeHeadersAllowList(const String& headerValue, HTTPHea derSet&);	58 void parseAccessControlExposeHeadersAllowList(const String& headerValue, HTTPHea derSet&);

	59 bool checkCrossOriginAccessRedirectionUrl(const KURL&, String& errorDescription) ;
	abarth-chromium 2014/01/31 23:42:40 Url -> URL Rather than using the verb "check", it Url -> URL Rather than using the verb "check", it would be better to explain what the function is checking. For example, crossOriginAccessControlRedirectForbiddenForURL sof 2014/02/04 22:01:50 CrossOriginAccessControl::isLegalRedirectLocation( Show quoted text On 2014/01/31 23:42:40, abarth wrote: > Url -> URL > > Rather than using the verb "check", it would be better to explain what the > function is checking. For example, > crossOriginAccessControlRedirectForbiddenForURL CrossOriginAccessControl::isLegalRedirectLocation() is what it was named in the patchset uploaded over the weekend.
59	60

60 } // namespace WebCore	61 } // namespace WebCore

61	62

62 #endif // CrossOriginAccessControl_h	63 #endif // CrossOriginAccessControl_h

OLD	NEW