Add trivial git-bash so that it can always drop you into a bash term,

Add trivial git-bash so that it can always drop you into a bash term,
even on windows.

R=mattm@chromium.org, mmoss@chromium.org, vadimsh@chromium.org
BUG=345142
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297854

[Dirk Pranke, 2015-12-04 22:25:55]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-12-04 22:25:55]

how does this do anything useful at all?

[iannucci, 2015-12-04 22:35:32]

See the bug. Basically it's an alias that will always point at the
currently-installed bash.exe, since the git folder can change when the git
version changes.

On Fri, Dec 4, 2015, 14:25  <dpranke@chromium.org> wrote:

> how does this do anything useful at all?
>
> https://codereview.chromium.org/1496343003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[mattm, 2015-12-04 22:49:12]

cute. Just tested and it does work. Would change it to allow passing args
though.

https://codereview.chromium.org/1496343003/diff/1/git-bash
File git-bash (right):

https://codereview.chromium.org/1496343003/diff/1/git-bash#newcode6
git-bash:6: bash
bash "$@"

or even:
exec bash "$@"

[iannucci, 2015-12-04 22:51:31]

exec is a problem on windows, IIRC, but the first one should work.

On Fri, Dec 4, 2015, 14:49  <mattm@chromium.org> wrote:

> cute. Just tested and it does work. Would change it to allow passing args
> though.
>
>
> https://codereview.chromium.org/1496343003/diff/1/git-bash
> File git-bash (right):
>
> https://codereview.chromium.org/1496343003/diff/1/git-bash#newcode6
> git-bash:6
>
<https://codereview.chromium.org/1496343003/diff/1/git-bash#newcode6git-bash:6>:
> bash
> bash "$@"
>
> or even:
> exec bash "$@"
>
> https://codereview.chromium.org/1496343003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[iannucci, 2015-12-04 23:38:47]

ptal

[iannucci, 2015-12-05 00:24:23]

Anyone? :D This one's not hard...

[mmoss, 2015-12-05 00:26:56]

lgtm

[iannucci, 2015-12-05 00:29:03]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2015-12-05 00:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496343003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496343003/40001

[commit-bot: I haz the power, 2015-12-05 00:43:46]

Description was changed from

==========
Add trivial git-bash so that it can always drop you into a bash term,
even on windows.

R=mattm@chromium.org, mmoss@chromium.org, vadimsh@chromium.org
BUG=345142
==========

to

==========
Add trivial git-bash so that it can always drop you into a bash term,
even on windows.

R=mattm@chromium.org, mmoss@chromium.org, vadimsh@chromium.org
BUG=345142

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297854
==========

[commit-bot: I haz the power, 2015-12-05 00:43:47]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297854