Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1496333002: Support intriscDefaultProto for Error functions (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Igor Sheludko, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support intriscDefaultProto for Error functions BUG=v8:3900, v8:3931, v8:1543, v8:3330, v8:4002 LOG=n Committed: https://crrev.com/175c90f8f2657f22e582ca9537dfe5f1a57e2856 Cr-Commit-Position: refs/heads/master@{#32692}

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : Rebase and make webkit test es6 compliant #

Patch Set 7 : mark test262 test as fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -91 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 5 3 chunks +59 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 2 3 4 5 1 chunk +8 lines, -15 lines 0 comments Download
M src/js/messages.js View 1 2 3 3 chunks +35 lines, -56 lines 0 comments Download
M test/mjsunit/error-constructors.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/classes-proxy.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/reflect-construct.js View 2 chunks +7 lines, -7 lines 0 comments Download
M test/test262/test262.status View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M test/webkit/fast/js/native-error-prototype.js View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/fast/js/native-error-prototype-expected.txt View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
Toon Verwaest
@ishell: please look at the intrinsic default proto part @yangguo: please look at the updated ...
5 years ago (2015-12-04 15:06:51 UTC) #2
Igor Sheludko
https://codereview.chromium.org/1496333002/diff/20001/src/js/messages.js File src/js/messages.js (right): https://codereview.chromium.org/1496333002/diff/20001/src/js/messages.js#newcode915 src/js/messages.js:915: %AddNamedProperty(error_function.prototype, 'name', name, DONT_ENUM); Why not set the prototype ...
5 years ago (2015-12-04 17:06:10 UTC) #3
Toon Verwaest
ptal again https://codereview.chromium.org/1496333002/diff/80001/test/mjsunit/error-constructors.js File test/mjsunit/error-constructors.js (right): https://codereview.chromium.org/1496333002/diff/80001/test/mjsunit/error-constructors.js#newcode131 test/mjsunit/error-constructors.js:131: assertEquals("[object Object]", Error.prototype.toString()); This should print "Error" ...
5 years ago (2015-12-07 13:54:06 UTC) #4
Igor Sheludko
lgtm
5 years ago (2015-12-08 08:29:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496333002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496333002/80001
5 years ago (2015-12-08 09:11:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8644)
5 years ago (2015-12-08 09:17:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496333002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496333002/100001
5 years ago (2015-12-08 10:31:07 UTC) #12
Yang
On 2015/12/08 10:31:07, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years ago (2015-12-08 11:14:24 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11751)
5 years ago (2015-12-08 12:00:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496333002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496333002/100001
5 years ago (2015-12-08 19:44:20 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/9696)
5 years ago (2015-12-08 20:23:11 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496333002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496333002/120001
5 years ago (2015-12-09 06:57:06 UTC) #23
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years ago (2015-12-09 07:53:25 UTC) #25
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/175c90f8f2657f22e582ca9537dfe5f1a57e2856 Cr-Commit-Position: refs/heads/master@{#32692}
5 years ago (2015-12-09 07:53:43 UTC) #27
Michael Achenbach
5 years ago (2015-12-09 08:59:05 UTC) #28
Message was sent while issue was closed. 
A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1510153002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Changes laytout tests. Please rebase
upstream first:

https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui...

Note: it seems to fix the tests. Nevertheless, rebaseline is required first.
.

Powered by Google App Engine
This is Rietveld 408576698