Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: sync/internal_api/sync_manager_impl.cc

Issue 14963002: sync: Report GetUpdate triggers to the server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review response: lots of renames Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/sync_manager_impl.cc
diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc
index aae5d418543d163dea1cac4019d80a3c2658a571..c83ab25c92f51ffda9bd45ffacaf3ffe4666d43b 100644
--- a/sync/internal_api/sync_manager_impl.cc
+++ b/sync/internal_api/sync_manager_impl.cc
@@ -955,8 +955,7 @@ void SyncManagerImpl::RequestNudgeForDataTypes(
types.First().Get(),
this);
allstatus_.IncrementNudgeCounter(NUDGE_SOURCE_LOCAL);
- scheduler_->ScheduleNudgeAsync(nudge_delay,
- NUDGE_SOURCE_LOCAL,
+ scheduler_->ScheduleLocalNudge(nudge_delay,
types,
nudge_location);
}
@@ -1259,9 +1258,8 @@ void SyncManagerImpl::OnIncomingInvalidation(
LOG(WARNING) << "Sync received invalidation without any type information.";
} else {
allstatus_.IncrementNudgeCounter(NUDGE_SOURCE_NOTIFICATION);
- scheduler_->ScheduleNudgeWithStatesAsync(
+ scheduler_->ScheduleInvalidationNudge(
TimeDelta::FromMilliseconds(kSyncSchedulerDelayMsec),
- NUDGE_SOURCE_NOTIFICATION,
type_invalidation_map, FROM_HERE);
allstatus_.IncrementNotificationsReceived();
UpdateNotificationInfo(type_invalidation_map);
@@ -1289,27 +1287,22 @@ void SyncManagerImpl::OnIncomingInvalidation(
void SyncManagerImpl::RefreshTypes(ModelTypeSet types) {
DCHECK(thread_checker_.CalledOnValidThread());
- const ModelTypeInvalidationMap& type_invalidation_map =
- ModelTypeSetToInvalidationMap(types, std::string());
- if (type_invalidation_map.empty()) {
+ if (types.Empty()) {
LOG(WARNING) << "Sync received refresh request with no types specified.";
} else {
allstatus_.IncrementNudgeCounter(NUDGE_SOURCE_LOCAL_REFRESH);
- scheduler_->ScheduleNudgeWithStatesAsync(
+ scheduler_->ScheduleLocalRefreshRequest(
TimeDelta::FromMilliseconds(kSyncRefreshDelayMsec),
- NUDGE_SOURCE_LOCAL_REFRESH,
- type_invalidation_map, FROM_HERE);
+ types, FROM_HERE);
}
if (js_event_handler_.IsInitialized()) {
base::DictionaryValue details;
base::ListValue* changed_types = new base::ListValue();
details.Set("changedTypes", changed_types);
- for (ModelTypeInvalidationMap::const_iterator it =
- type_invalidation_map.begin(); it != type_invalidation_map.end();
- ++it) {
+ for (ModelTypeSet::Iterator it = types.First(); it.Good(); it.Inc()) {
const std::string& model_type_str =
- ModelTypeToString(it->first);
+ ModelTypeToString(it.Get());
changed_types->Append(new base::StringValue(model_type_str));
}
details.SetString("source", "LOCAL_INVALIDATION");

Powered by Google App Engine
This is Rietveld 408576698