Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: sync/engine/sync_scheduler.h

Issue 14963002: sync: Report GetUpdate triggers to the server (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review response: lots of renames Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/engine/sync_scheduler.h
diff --git a/sync/engine/sync_scheduler.h b/sync/engine/sync_scheduler.h
index b2ebbe3f0484862b9f0c50a6d82e54b61f7dee36..11915cf6b0394d84a82cbb81c85ac50ce8be580f 100644
--- a/sync/engine/sync_scheduler.h
+++ b/sync/engine/sync_scheduler.h
@@ -83,20 +83,23 @@ class SYNC_EXPORT_PRIVATE SyncScheduler
// are cancelled.
virtual void RequestStop(const base::Closure& callback) = 0;
- // The meat and potatoes. Both of these methods will post a delayed task
+ // The meat and potatoes. All three of these methods will post a delayed task
// to attempt the actual nudge (see ScheduleNudgeImpl).
// NOTE: |desired_delay| is best-effort. If a nudge is already scheduled to
// depart earlier than Now() + delay, the scheduler can and will prefer to
// batch the two so that only one nudge is sent (at the earlier time). Also,
// as always with delayed tasks and timers, it's possible the task gets run
// any time after |desired_delay|.
- virtual void ScheduleNudgeAsync(
+ virtual void ScheduleLocalNudge(
const base::TimeDelta& desired_delay,
- NudgeSource source,
ModelTypeSet types,
const tracked_objects::Location& nudge_location) = 0;
- virtual void ScheduleNudgeWithStatesAsync(
- const base::TimeDelta& desired_delay, NudgeSource source,
+ virtual void ScheduleLocalRefreshRequest(
tim (not reviewing) 2013/05/07 20:34:13 We should update the comment here to introduce the
rlarocque 2013/05/07 21:50:57 Done.
+ const base::TimeDelta& desired_delay,
+ ModelTypeSet types,
+ const tracked_objects::Location& nudge_location) = 0;
+ virtual void ScheduleInvalidationNudge(
+ const base::TimeDelta& desired_delay,
const ModelTypeInvalidationMap& invalidation_map,
const tracked_objects::Location& nudge_location) = 0;

Powered by Google App Engine
This is Rietveld 408576698