Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1496293002: Revert of [es6] Match ArrayBuffer constructor behavior of Firefox. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Match ArrayBuffer constructor behavior of Firefox. (patchset #1 id:1 of https://codereview.chromium.org/1497163002/ ) Reason for revert: Blocks the roll: https://codereview.chromium.org/1497763004/ Original issue's description: > [es6] Match ArrayBuffer constructor behavior of Firefox. > > We choose to deliberately violate the ES2015 specification and implement > the ArrayBuffer constructor in a way that matches Firefox and Safari > instead. > > BUG=v8:4592 > LOG=n > > Committed: https://crrev.com/8aae841ce26f01f3535e54af3a58fb7c65833eb7 > Cr-Commit-Position: refs/heads/master@{#32597} TBR=jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4592 Committed: https://crrev.com/9730118946938262b090f88d5ed8fd461a04f0a9 Cr-Commit-Position: refs/heads/master@{#32605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [es6] Match ArrayBuffer constructor behavior of Firefox.
5 years ago (2015-12-04 10:37:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1496293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1496293002/1
5 years ago (2015-12-04 10:37:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 10:37:15 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-04 10:37:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9730118946938262b090f88d5ed8fd461a04f0a9
Cr-Commit-Position: refs/heads/master@{#32605}

Powered by Google App Engine
This is Rietveld 408576698