[proxies] Implement Proxy.revocable.

[proxies] Implement Proxy.revocable.

For now, we revoke a proxy by setting its handler to null (as in the spec).

Change the "target" field from Object to JSReceiver as there's no point in
allowing more.

R=jkummerow@chromium.org, rossberg
BUG=v8:1543
LOG=n

Committed: https://crrev.com/62127d00aec05847a7e1fc863290fc5d8e8799ce
Cr-Commit-Position: refs/heads/master@{#32608}

[neis, 2015-12-04 09:42:25]

Description was changed from

==========
[proxies] Implement Proxy.revocable.

For now, we revoke a proxy by setting its handler to null (as in the spec).

Change the "target" field from Object to JSReceiver as there's no point in
allowing more.

R=jkummerow@chromium.org, rossberg
BUG=
==========

to

==========
[proxies] Implement Proxy.revocable.

For now, we revoke a proxy by setting its handler to null (as in the spec).

Change the "target" field from Object to JSReceiver as there's no point in
allowing more.

R=jkummerow@chromium.org, rossberg
BUG=v8:1543
LOG=n
==========

[Jakob Kummerow, 2015-12-04 09:51:30]

LGTM with nits.

https://codereview.chromium.org/1496243003/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1496243003/diff/1/src/objects.cc#newcode4613
src/objects.cc:4613: auto isolate = proxy->GetIsolate();
nit: I'd prefer s/auto/Isolate*/.

The rule of thumb is to only use "auto" when it avoids a significant amount of
boilerplate, like when working with std:: iterators.

https://codereview.chromium.org/1496243003/diff/1/src/objects.cc#newcode4618
src/objects.cc:4618: return isolate->factory()->undefined_value();
Is there a reason this method doesn't return void?

[neis, 2015-12-04 10:34:08]

On 2015/12/04 09:51:30, Jakob wrote:
> LGTM with nits.
> 
> https://codereview.chromium.org/1496243003/diff/1/src/objects.cc
> File src/objects.cc (right):
> 
> https://codereview.chromium.org/1496243003/diff/1/src/objects.cc#newcode4613
> src/objects.cc:4613: auto isolate = proxy->GetIsolate();
> nit: I'd prefer s/auto/Isolate*/.
> 
> The rule of thumb is to only use "auto" when it avoids a significant amount of
> boilerplate, like when working with std:: iterators.

Ok.

> https://codereview.chromium.org/1496243003/diff/1/src/objects.cc#newcode4618
> src/objects.cc:4618: return isolate->factory()->undefined_value();
> Is there a reason this method doesn't return void?

Not a good one.  Changed it.

[neis, 2015-12-04 10:34:11]

The CQ bit was checked by neis@chromium.org

[neis, 2015-12-04 10:34:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1496243003/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2015-12-04 10:34:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496243003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496243003/20001

[neis, 2015-12-04 10:45:09]

The CQ bit was unchecked by neis@chromium.org

[neis, 2015-12-04 10:45:35]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2015-12-04 10:45:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496243003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496243003/20001

[commit-bot: I haz the power, 2015-12-04 10:55:26]

Description was changed from

==========
[proxies] Implement Proxy.revocable.

For now, we revoke a proxy by setting its handler to null (as in the spec).

Change the "target" field from Object to JSReceiver as there's no point in
allowing more.

R=jkummerow@chromium.org, rossberg
BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Implement Proxy.revocable.

For now, we revoke a proxy by setting its handler to null (as in the spec).

Change the "target" field from Object to JSReceiver as there's no point in
allowing more.

R=jkummerow@chromium.org, rossberg
BUG=v8:1543
LOG=n
==========

[commit-bot: I haz the power, 2015-12-04 10:55:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-04 10:56:11]

Description was changed from

==========
[proxies] Implement Proxy.revocable.

For now, we revoke a proxy by setting its handler to null (as in the spec).

Change the "target" field from Object to JSReceiver as there's no point in
allowing more.

R=jkummerow@chromium.org, rossberg
BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Implement Proxy.revocable.

For now, we revoke a proxy by setting its handler to null (as in the spec).

Change the "target" field from Object to JSReceiver as there's no point in
allowing more.

R=jkummerow@chromium.org, rossberg
BUG=v8:1543
LOG=n

Committed: https://crrev.com/62127d00aec05847a7e1fc863290fc5d8e8799ce
Cr-Commit-Position: refs/heads/master@{#32608}
==========

[commit-bot: I haz the power, 2015-12-04 10:56:14]

Patchset 2 (id:??) landed as
https://crrev.com/62127d00aec05847a7e1fc863290fc5d8e8799ce
Cr-Commit-Position: refs/heads/master@{#32608}