Fix issue 5275: The VM must always generate the most compact form of an integer (Smi, Mint or Bigin…

runtime/lib/typed_data.cc

Index: runtime/lib/typed_data.cc
===================================================================
--- runtime/lib/typed_data.cc	(revision 22802)
+++ runtime/lib/typed_data.cc	(working copy)
@@ -259,7 +259,7 @@
   if (value > static_cast<uint64_t>(Mint::kMaxValue)) {                        \
     result = BigintOperations::NewFromUint64(value);                           \
   } else if (value > static_cast<uint64_t>(Smi::kMaxValue)) {                  \

[siva, 2013/05/16 19:52:50]

Ditto comment here.

This could just be:
} else {
  result = Integer::New(value);
}

[srdjan, 2013/05/16 20:03:31]

Done.

-    result = Mint::New(value);                                                 \
+    result = Integer::New(value);                                              \
   } else {                                                                     \
     result = Smi::New(value);                                                  \
   }                                                                            \
@@ -410,7 +410,7 @@
   if (value > static_cast<uint64_t>(Mint::kMaxValue)) {
     return BigintOperations::NewFromUint64(value);
   } else if (value > static_cast<uint64_t>(Smi::kMaxValue)) {
-    return Mint::New(value);
+    return Integer::New(value);

[siva, 2013/05/16 19:52:50]

Ditto here too.
it could just be:

return Integer::New(value);

[srdjan, 2013/05/16 20:03:31]

Done.

   }
   return Smi::New(value);
 }