Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: webkit/glue/chromium_bridge_impl.cc

Issue 149620: Use WebWidget from the WebKit API. This change also makes... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/chrome_client_impl.cc ('k') | webkit/glue/context_menu_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/chromium_bridge_impl.cc
===================================================================
--- webkit/glue/chromium_bridge_impl.cc (revision 20851)
+++ webkit/glue/chromium_bridge_impl.cc (working copy)
@@ -47,6 +47,7 @@
#endif
using WebKit::WebCursorInfo;
+using WebKit::WebWidgetClient;
namespace {
@@ -73,11 +74,11 @@
return static_cast<ChromeClientImpl*>(page->chrome()->client());
}
-WebViewImpl* ToWebView(WebCore::Widget* widget) {
+WebWidgetClient* ToWebWidgetClient(WebCore::Widget* widget) {
ChromeClientImpl* chrome_client = ToChromeClient(widget);
- if (!chrome_client)
+ if (!chrome_client || !chrome_client->webview())
return NULL;
- return chrome_client->webview();
+ return chrome_client->webview()->delegate();
}
WebCore::IntRect ToIntRect(const WebKit::WebRect& input) {
@@ -95,14 +96,10 @@
return;
// Dispatch to the delegate of the view that owns the frame.
- WebFrame* webframe = WebFrameImpl::FromFrame(frame);
- WebView* webview = webframe->GetView();
- if (!webview)
+ WebViewImpl* webview = WebFrameImpl::FromFrame(frame)->GetWebViewImpl();
+ if (!webview || !webview->delegate())
return;
- WebViewDelegate* delegate = webview->GetDelegate();
- if (!delegate)
- return;
- delegate->JSOutOfMemory();
+ webview->delegate()->JSOutOfMemory();
}
// Plugin ---------------------------------------------------------------------
@@ -138,38 +135,38 @@
// Screen ---------------------------------------------------------------------
int ChromiumBridge::screenDepth(Widget* widget) {
- WebViewImpl* view = ToWebView(widget);
- if (!view || !view->delegate())
- return NULL;
- return view->delegate()->GetScreenInfo(view).depth;
+ WebWidgetClient* client = ToWebWidgetClient(widget);
+ if (!client)
+ return 0;
+ return client->screenInfo().depth;
}
int ChromiumBridge::screenDepthPerComponent(Widget* widget) {
- WebViewImpl* view = ToWebView(widget);
- if (!view || !view->delegate())
- return NULL;
- return view->delegate()->GetScreenInfo(view).depthPerComponent;
+ WebWidgetClient* client = ToWebWidgetClient(widget);
+ if (!client)
+ return 0;
+ return client->screenInfo().depthPerComponent;
}
bool ChromiumBridge::screenIsMonochrome(Widget* widget) {
- WebViewImpl* view = ToWebView(widget);
- if (!view || !view->delegate())
- return NULL;
- return view->delegate()->GetScreenInfo(view).isMonochrome;
+ WebWidgetClient* client = ToWebWidgetClient(widget);
+ if (!client)
+ return false;
+ return client->screenInfo().isMonochrome;
}
IntRect ChromiumBridge::screenRect(Widget* widget) {
- WebViewImpl* view = ToWebView(widget);
- if (!view || !view->delegate())
+ WebWidgetClient* client = ToWebWidgetClient(widget);
+ if (!client)
return IntRect();
- return ToIntRect(view->delegate()->GetScreenInfo(view).rect);
+ return ToIntRect(client->screenInfo().rect);
}
IntRect ChromiumBridge::screenAvailableRect(Widget* widget) {
- WebViewImpl* view = ToWebView(widget);
- if (!view || !view->delegate())
+ WebWidgetClient* client = ToWebWidgetClient(widget);
+ if (!client)
return IntRect();
- return ToIntRect(view->delegate()->GetScreenInfo(view).availableRect);
+ return ToIntRect(client->screenInfo().availableRect);
}
// Widget ---------------------------------------------------------------------
« no previous file with comments | « webkit/glue/chrome_client_impl.cc ('k') | webkit/glue/context_menu_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698