Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1496163002: [assert] Exclude static_assert macro when using C++ (Closed)

Created:
5 years ago by cpu_(ooo_6.6-7.5)
Modified:
5 years ago
Reviewers:
travisg
Base URL:
https://github.com/travisg/lk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[assert] Exclude static_assert macro when using C++ Macro cannot be removed because it breaks lpclink2-lpcboot and others. Fixes errors like: In file included from third_party/lk/include/lib/page_alloc.h:32:0, from app/fletch/loader.cpp:15: third_party/lk/include/kernel/vm.h:70:96: error: macro "static_assert" passed 2 arguments, but takes just 1 STATIC_ASSERT(__offsetof(struct mmu_initial_mapping, phys) == __MMU_INITIAL_MAPPING_PHYS_OFFSET); ^ third_party/lk/include/kernel/vm.h:70:1: warning: identifier 'static_assert' is a keyword in C++11 [-Wc++0x-compat] BUG= R=travisg@google.com Committed: d31bd3d5efa0dc3ba8b85e274236a0d45c98b570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/assert.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
travisg
lgtm
5 years ago (2015-12-03 23:22:17 UTC) #2
cpu_(ooo_6.6-7.5)
5 years ago (2015-12-03 23:25:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d31bd3d5efa0dc3ba8b85e274236a0d45c98b570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698