Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: net/proxy/proxy_config_service_linux.cc

Issue 149614: Fix the log error message about proxy authentication in... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_config_service_linux.cc
===================================================================
--- net/proxy/proxy_config_service_linux.cc (revision 20619)
+++ net/proxy/proxy_config_service_linux.cc (working copy)
@@ -72,8 +72,10 @@
std::string::size_type at_sign = host.find("@");
// Should this be supported?
if (at_sign != std::string::npos) {
- LOG(ERROR) << "Proxy authentication not supported";
- // Disregard the authentication parameters and continue with this hostname.
+ // ProxyConfig does not support authentication parameters, but Chrome
+ // will prompt for the password later. Disregard the
+ // authentication parameters and continue with this hostname.
+ LOG(WARNING) << "Proxy authentication parameters ignored, see bug 16709";
host = host.substr(at_sign + 1);
}
// If this is a socks proxy, prepend a scheme so as to tell
@@ -509,8 +511,12 @@
bool use_auth;
gconf_getter_->GetBoolean("/system/http_proxy/use_authentication",
&use_auth);
- if (use_auth)
- LOG(ERROR) << "Proxy authentication not supported";
+ if (use_auth) {
+ // ProxyConfig does not support authentication parameters, but
+ // Chrome will prompt for the password later. So we ignore
+ // /system/http_proxy/*auth* settings.
+ LOG(WARNING) << "Proxy authentication parameters ignored, see bug 16709";
+ }
// Now the bypass list.
gconf_getter_->GetStringList("/system/http_proxy/ignore_hosts",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698