Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: cc/surfaces/display_unittest.cc

Issue 1496103002: Reusing base::IdType<...> to implement SurfaceId. Base URL: https://chromium.googlesource.com/chromium/src.git@type-safe-id-base
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/surfaces/display_scheduler_unittest.cc ('k') | cc/surfaces/surface_aggregator_perftest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/null_task_runner.h" 5 #include "base/test/null_task_runner.h"
6 #include "cc/output/compositor_frame.h" 6 #include "cc/output/compositor_frame.h"
7 #include "cc/output/copy_output_result.h" 7 #include "cc/output/copy_output_result.h"
8 #include "cc/output/delegated_frame_data.h" 8 #include "cc/output/delegated_frame_data.h"
9 #include "cc/quads/render_pass.h" 9 #include "cc/quads/render_pass.h"
10 #include "cc/resources/shared_bitmap_manager.h" 10 #include "cc/resources/shared_bitmap_manager.h"
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 SetUpContext(nullptr); 156 SetUpContext(nullptr);
157 TestDisplayClient client; 157 TestDisplayClient client;
158 RendererSettings settings; 158 RendererSettings settings;
159 Display display(&client, &manager_, shared_bitmap_manager_.get(), nullptr, 159 Display display(&client, &manager_, shared_bitmap_manager_.get(), nullptr,
160 settings); 160 settings);
161 161
162 TestDisplayScheduler scheduler(&display, &fake_begin_frame_source_, 162 TestDisplayScheduler scheduler(&display, &fake_begin_frame_source_,
163 task_runner_.get()); 163 task_runner_.get());
164 display.Initialize(std::move(output_surface_), &scheduler); 164 display.Initialize(std::move(output_surface_), &scheduler);
165 165
166 SurfaceId surface_id(6); 166 SurfaceId surface_id = SurfaceId::FromUnsafeValue(6);
167 factory_.Create(surface_id); 167 factory_.Create(surface_id);
168 Surface* surface = manager_.GetSurfaceForId(surface_id); 168 Surface* surface = manager_.GetSurfaceForId(surface_id);
169 169
170 EXPECT_EQ(nullptr, surface_factory_client_.begin_frame_source()); 170 EXPECT_EQ(nullptr, surface_factory_client_.begin_frame_source());
171 display.AddSurface(surface); 171 display.AddSurface(surface);
172 EXPECT_NE(nullptr, surface_factory_client_.begin_frame_source()); 172 EXPECT_NE(nullptr, surface_factory_client_.begin_frame_source());
173 display.RemoveSurface(surface); 173 display.RemoveSurface(surface);
174 EXPECT_EQ(nullptr, surface_factory_client_.begin_frame_source()); 174 EXPECT_EQ(nullptr, surface_factory_client_.begin_frame_source());
175 } 175 }
176 176
177 // Check that frame is damaged and swapped only under correct conditions. 177 // Check that frame is damaged and swapped only under correct conditions.
178 TEST_F(DisplayTest, DisplayDamaged) { 178 TEST_F(DisplayTest, DisplayDamaged) {
179 SetUpContext(nullptr); 179 SetUpContext(nullptr);
180 TestDisplayClient client; 180 TestDisplayClient client;
181 RendererSettings settings; 181 RendererSettings settings;
182 settings.partial_swap_enabled = true; 182 settings.partial_swap_enabled = true;
183 settings.finish_rendering_on_resize = true; 183 settings.finish_rendering_on_resize = true;
184 Display display(&client, &manager_, shared_bitmap_manager_.get(), nullptr, 184 Display display(&client, &manager_, shared_bitmap_manager_.get(), nullptr,
185 settings); 185 settings);
186 186
187 TestDisplayScheduler scheduler(&display, &fake_begin_frame_source_, 187 TestDisplayScheduler scheduler(&display, &fake_begin_frame_source_,
188 task_runner_.get()); 188 task_runner_.get());
189 display.Initialize(std::move(output_surface_), &scheduler); 189 display.Initialize(std::move(output_surface_), &scheduler);
190 190
191 SurfaceId surface_id(7u); 191 SurfaceId surface_id = SurfaceId::FromUnsafeValue(7u);
192 EXPECT_FALSE(scheduler.damaged); 192 EXPECT_FALSE(scheduler.damaged);
193 EXPECT_FALSE(scheduler.has_new_root_surface); 193 EXPECT_FALSE(scheduler.has_new_root_surface);
194 display.SetSurfaceId(surface_id, 1.f); 194 display.SetSurfaceId(surface_id, 1.f);
195 EXPECT_FALSE(scheduler.damaged); 195 EXPECT_FALSE(scheduler.damaged);
196 EXPECT_FALSE(scheduler.display_resized_); 196 EXPECT_FALSE(scheduler.display_resized_);
197 EXPECT_TRUE(scheduler.has_new_root_surface); 197 EXPECT_TRUE(scheduler.has_new_root_surface);
198 198
199 scheduler.ResetDamageForTest(); 199 scheduler.ResetDamageForTest();
200 display.Resize(gfx::Size(100, 100)); 200 display.Resize(gfx::Size(100, 100));
201 EXPECT_FALSE(scheduler.damaged); 201 EXPECT_FALSE(scheduler.damaged);
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
414 RendererSettings settings; 414 RendererSettings settings;
415 settings.partial_swap_enabled = true; 415 settings.partial_swap_enabled = true;
416 settings.finish_rendering_on_resize = true; 416 settings.finish_rendering_on_resize = true;
417 Display display(&client, &manager_, shared_bitmap_manager_.get(), nullptr, 417 Display display(&client, &manager_, shared_bitmap_manager_.get(), nullptr,
418 settings); 418 settings);
419 419
420 TestDisplayScheduler scheduler(&display, &fake_begin_frame_source_, 420 TestDisplayScheduler scheduler(&display, &fake_begin_frame_source_,
421 task_runner_.get()); 421 task_runner_.get());
422 display.Initialize(std::move(output_surface_), &scheduler); 422 display.Initialize(std::move(output_surface_), &scheduler);
423 423
424 SurfaceId surface_id(7u); 424 SurfaceId surface_id = SurfaceId::FromUnsafeValue(7u);
425 display.SetSurfaceId(surface_id, 1.f); 425 display.SetSurfaceId(surface_id, 1.f);
426 426
427 display.Resize(gfx::Size(100, 100)); 427 display.Resize(gfx::Size(100, 100));
428 factory_.Create(surface_id); 428 factory_.Create(surface_id);
429 429
430 { 430 {
431 RenderPassList pass_list; 431 RenderPassList pass_list;
432 scoped_ptr<RenderPass> pass = RenderPass::Create(); 432 scoped_ptr<RenderPass> pass = RenderPass::Create();
433 pass->output_rect = gfx::Rect(0, 0, 100, 100); 433 pass->output_rect = gfx::Rect(0, 0, 100, 100);
434 pass->damage_rect = gfx::Rect(10, 10, 1, 1); 434 pass->damage_rect = gfx::Rect(10, 10, 1, 1);
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 470
471 EXPECT_CALL(*context_ptr, shallowFinishCHROMIUM()); 471 EXPECT_CALL(*context_ptr, shallowFinishCHROMIUM());
472 display.Resize(gfx::Size(250, 250)); 472 display.Resize(gfx::Size(250, 250));
473 testing::Mock::VerifyAndClearExpectations(context_ptr); 473 testing::Mock::VerifyAndClearExpectations(context_ptr);
474 474
475 factory_.Destroy(surface_id); 475 factory_.Destroy(surface_id);
476 } 476 }
477 477
478 } // namespace 478 } // namespace
479 } // namespace cc 479 } // namespace cc
OLDNEW
« no previous file with comments | « cc/surfaces/display_scheduler_unittest.cc ('k') | cc/surfaces/surface_aggregator_perftest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698