Issue 149603009: [Mac] Sort the "other" profiles correctly in the new avatar bubble.

Issue 149603009: [Mac] Sort the "other" profiles correctly in the new avatar bubble. (Closed)

Created:
6 years, 10 months ago by noms (inactive)

Modified:
6 years, 10 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mac] Sort the "other" profiles correctly in the new avatar bubble. Because we draw things in reverse in Cocoa, we should iterate through the avatar items in reverse too. BUG=341972 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251068

Patch Set 1 #

Patch Set 2 : ++test #

Total comments: 2

Patch Set 3 : unbreak existing test #

Patch Set 4 : fix comment #

Patch Set 5 : nit #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -6 lines)			Patch
	M	chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm	View	1 2 3	2 chunks	+5 lines, -3 lines	0 comments	Download
	M	chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm	View	1 2 3 4	2 chunks	+35 lines, -3 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Alexei Svitkine (slow)

lgtm, but would be even better if there was a test!

6 years, 10 months ago (2014-02-12 16:34:45 UTC) #2

Alexei Svitkine (slow)

lgtm, thanks https://codereview.chromium.org/149603009/diff/100001/chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm File chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm (right): https://codereview.chromium.org/149603009/diff/100001/chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm#newcode150 chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm:150: @"Test 2"}; Nit: Space before }

6 years, 10 months ago (2014-02-12 22:03:15 UTC) #4

noms (inactive)

https://codereview.chromium.org/149603009/diff/100001/chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm File chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm (right): https://codereview.chromium.org/149603009/diff/100001/chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm#newcode150 chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm:150: @"Test 2"}; On 2014/02/12 22:03:15, Alexei Svitkine wrote: > ...

6 years, 10 months ago (2014-02-13 14:46:15 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/149603009/300001

6 years, 10 months ago (2014-02-13 14:46:53 UTC) #7

Message was sent while issue was closed.

Change committed as 251068

Expand Messages | Collapse Messages