Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 149603003: Fix stack height assertion code and free up a bit in the Function tag bits. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 32017)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -78,23 +78,17 @@
Register result = locs()->in(0).reg();
ASSERT(result == EAX);
#if defined(DEBUG)
- // TODO(srdjan): Fix for functions with finally clause.
- // A finally clause may leave a previously pushed return value if it
- // has its own return instruction. Method that have finally are currently
- // not optimized.
- if (!compiler->HasFinally()) {
- __ Comment("Stack Check");
- Label done;
- const intptr_t fp_sp_dist =
- (kFirstLocalSlotFromFp + 1 - compiler->StackSize()) * kWordSize;
- ASSERT(fp_sp_dist <= 0);
- __ movl(EDI, ESP);
- __ subl(EDI, EBP);
- __ cmpl(EDI, Immediate(fp_sp_dist));
- __ j(EQUAL, &done, Assembler::kNearJump);
- __ int3();
- __ Bind(&done);
- }
+ __ Comment("Stack Check");
+ Label done;
+ const intptr_t fp_sp_dist =
+ (kFirstLocalSlotFromFp + 1 - compiler->StackSize()) * kWordSize;
+ ASSERT(fp_sp_dist <= 0);
+ __ movl(EDI, ESP);
+ __ subl(EDI, EBP);
+ __ cmpl(EDI, Immediate(fp_sp_dist));
+ __ j(EQUAL, &done, Assembler::kNearJump);
+ __ int3();
+ __ Bind(&done);
#endif
__ LeaveFrame();
__ ret();
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698