MIPS:[turbofan] Match shift left and bitwise And with mask when possible.

MIPS:[turbofan] Match shift left and bitwise And with mask when possible.

TEST=unittests/InstructionSelectorTest.Word(32|64)ShlWithWord(32|64)And
BUG=

Committed: https://crrev.com/472e2ba9b953fd6a00523c218f8a2c2cfe9741f3
Cr-Commit-Position: refs/heads/master@{#32612}

[dusan.milosavljevic, 2015-12-03 19:53:39]

dusan.m.milosavljevic@gmail.com changed reviewers:
+ bmeurer@chromium.org, paul.lind@imgtec.com, titzer@chromium.org

[dusan.milosavljevic, 2015-12-03 19:53:39]

PTAL.

[paul.l..., 2015-12-04 01:23:50]

lgtm

[titzer, 2015-12-04 09:26:59]

https://codereview.chromium.org/1496013003/diff/20001/src/compiler/mips/instr...
File src/compiler/mips/instruction-selector-mips.cc (right):

https://codereview.chromium.org/1496013003/diff/20001/src/compiler/mips/instr...
src/compiler/mips/instruction-selector-mips.cc:333: Int32BinopMatcher m(node);
Can we get a comment that illustrates the pattern that this code matches?

https://codereview.chromium.org/1496013003/diff/20001/src/compiler/mips64/ins...
File src/compiler/mips64/instruction-selector-mips64.cc (right):

https://codereview.chromium.org/1496013003/diff/20001/src/compiler/mips64/ins...
src/compiler/mips64/instruction-selector-mips64.cc:425: Int32BinopMatcher
m(node);
Here, too.

[dusan.milosavljevic, 2015-12-04 12:50:59]

https://codereview.chromium.org/1496013003/diff/20001/src/compiler/mips/instr...
File src/compiler/mips/instruction-selector-mips.cc (right):

https://codereview.chromium.org/1496013003/diff/20001/src/compiler/mips/instr...
src/compiler/mips/instruction-selector-mips.cc:333: Int32BinopMatcher m(node);
On 2015/12/04 09:26:58, titzer wrote:
> Can we get a comment that illustrates the pattern that this code matches?

Done.

https://codereview.chromium.org/1496013003/diff/20001/src/compiler/mips64/ins...
File src/compiler/mips64/instruction-selector-mips64.cc (right):

https://codereview.chromium.org/1496013003/diff/20001/src/compiler/mips64/ins...
src/compiler/mips64/instruction-selector-mips64.cc:425: Int32BinopMatcher
m(node);
On 2015/12/04 09:26:59, titzer wrote:
> Here, too.

Done.

[dusan.milosavljevic, 2015-12-04 12:53:42]

The CQ bit was checked by dusan.m.milosavljevic@gmail.com

[dusan.milosavljevic, 2015-12-04 12:53:42]

The patchset sent to the CQ was uploaded after l-g-t-m from paul.lind@imgtec.com
Link to the patchset: https://codereview.chromium.org/1496013003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-12-04 12:53:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1496013003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1496013003/60001

[titzer, 2015-12-04 12:59:18]

Thanks, LGTM

[commit-bot: I haz the power, 2015-12-04 13:12:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-04 13:13:12]

Description was changed from

==========
MIPS:[turbofan] Match shift left and bitwise And with mask when possible.

TEST=unittests/InstructionSelectorTest.Word(32|64)ShlWithWord(32|64)And
BUG=
==========

to

==========
MIPS:[turbofan] Match shift left and bitwise And with mask when possible.

TEST=unittests/InstructionSelectorTest.Word(32|64)ShlWithWord(32|64)And
BUG=

Committed: https://crrev.com/472e2ba9b953fd6a00523c218f8a2c2cfe9741f3
Cr-Commit-Position: refs/heads/master@{#32612}
==========

[commit-bot: I haz the power, 2015-12-04 13:13:13]

Patchset 4 (id:??) landed as
https://crrev.com/472e2ba9b953fd6a00523c218f8a2c2cfe9741f3
Cr-Commit-Position: refs/heads/master@{#32612}