Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1495933002: update completion extension point to use CompletionContributorFactory (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update completion extension point to use CompletionContributorFactory R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ac63bc8fe415f2100aa0029c4f7043a5630863d6

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/completion.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/completion_core.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
danrubel
5 years ago (2015-12-03 14:54:20 UTC) #2
scheglov
lgtm https://codereview.chromium.org/1495933002/diff/1/pkg/analysis_server/lib/src/plugin/server_plugin.dart File pkg/analysis_server/lib/src/plugin/server_plugin.dart (right): https://codereview.chromium.org/1495933002/diff/1/pkg/analysis_server/lib/src/plugin/server_plugin.dart#newcode194 pkg/analysis_server/lib/src/plugin/server_plugin.dart:194: .map((CompletionContributorFactory factory) => factory()); This code will fail ...
5 years ago (2015-12-03 14:58:30 UTC) #3
danrubel
Committed patchset #2 (id:20001) manually as ac63bc8fe415f2100aa0029c4f7043a5630863d6 (presubmit successful).
5 years ago (2015-12-03 15:02:09 UTC) #5
danrubel
5 years ago (2015-12-03 15:03:51 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1495933002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/plugin/server_plugin.dart (right):

https://codereview.chromium.org/1495933002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/plugin/server_plugin.dart:194:
.map((CompletionContributorFactory factory) => factory());
On 2015/12/03 14:58:30, scheglov wrote:
> This code will fail in the checked mode.
> Iterable is not List.

Thanks for the catch! Fixed.

Powered by Google App Engine
This is Rietveld 408576698