LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html - Issue 14959014: [CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html

Issue 14959014: [CSS Exclusions] Programmatic layout tests fail when subpixel layout is disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/exclusions/resources/subpixel-utils.js ('K') | « LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-layout-expected.txt ('k') | LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-padding-003-expected.txt » ('j') | Source/core/rendering/exclusions/ExclusionPolygon.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html

diff --git a/LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html b/LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html

index 4e13befa21f645d24752ce4ea63f0b586bb9cb26..c7a16a55cf31397f28c94dabf42ce0f3546e1abb 100644

--- a/LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html

+++ b/LayoutTests/fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html

@@ -2,6 +2,7 @@

<html>

<head>

+<script src="../resources/subpixel-utils.js"></script>

if (window.internals)

window.internals.settings.setCSSExclusionsEnabled(true);

@@ -70,8 +71,10 @@

+ var quiet = true; // PASS output depends on SubPixelLayout.isEnabled()

leviw_travelin_and_unemployed 2013/05/21 22:21:56 This is a sad change.

shouldBe("shapeInsideRect('a').top", "50");

- shouldBeCloseTo("shapeInsideRect('a').left", 190.215, 1);

+ shouldBeCloseTo("shapeInsideRect('a').left", SubPixelLayout.snapToLayoutUnit(190.215), 1, quiet);

shouldBe("shapeInsideRect('a').width", "150");

shouldBe("shapeInsideRect('b').top", "150");

@@ -79,7 +82,7 @@

shouldBe("shapeInsideRect('b').width", "100");

shouldBe("shapeInsideRect('c').top", "250");

- shouldBeCloseTo("shapeInsideRect('c').left", 190.215, 1);

+ shouldBeCloseTo("shapeInsideRect('c').left", SubPixelLayout.snapToLayoutUnit(190.215), 1, quiet);

shouldBe("shapeInsideRect('c').width", "150");

</script>

</html>