Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1495893005: Revert of Added an extra sync token field for extra command buffer identification. (Closed)

Created:
5 years ago by ajuma
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, qsr+mojo_chromium.org, rjkroege, sievers+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added an extra sync token field for extra command buffer identification. (patchset #8 id:140001 of https://codereview.chromium.org/1489573003/ ) Reason for revert: This is causing a large number of layout tests in virtual/threaded/animations to crash. They're hitting the following assertion: FATAL:scheduler.cc(203)] Check failed: state_machine_.pending_swaps() > 0 (0 vs. 0){"compositor_timing_history": e.g. see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/25835 Confirmed with a local bisect. Original issue's description: > Added an extra sync token field for extra command buffer identification. > > This CL adds an extra field within sync tokens without changing the size > of the sync token. Currently this extra field is only used for the > GPU channel implementation, storing the stream of the identified command > buffer. > > BUG=514815 > > Committed: https://crrev.com/f21e7e6e2b260d56fa54373dd662c81c9d955331 > Cr-Commit-Position: refs/heads/master@{#363231} TBR=dcheng@chromium.org,dalecurtis@chromium.org,piman@chromium.org,sky@chromium.org,dyen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514815 Committed: https://crrev.com/5097a2103f86741a7d0e6567e57759be939182b0 Cr-Commit-Position: refs/heads/master@{#363290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -114 lines) Patch
M components/mus/gles2/command_buffer_local.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 3 chunks +3 lines, -19 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 chunk +1 line, -5 lines 0 comments Download
M gpu/command_buffer/common/constants.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/sync_token.h View 6 chunks +0 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 6 chunks +5 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/mailbox_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_frame_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ajuma
Created Revert of Added an extra sync token field for extra command buffer identification.
5 years ago (2015-12-04 20:50:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1495893005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1495893005/1
5 years ago (2015-12-04 20:52:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 20:56:53 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-04 20:58:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5097a2103f86741a7d0e6567e57759be939182b0
Cr-Commit-Position: refs/heads/master@{#363290}

Powered by Google App Engine
This is Rietveld 408576698