Chromium Code Reviews
DescriptionRevert of Added an extra sync token field for extra command buffer identification. (patchset #8 id:140001 of https://codereview.chromium.org/1489573003/ )
Reason for revert:
This is causing a large number of layout tests in virtual/threaded/animations to crash.
They're hitting the following assertion:
FATAL:scheduler.cc(203)] Check failed: state_machine_.pending_swaps() > 0 (0 vs. 0){"compositor_timing_history":
e.g. see https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/25835
Confirmed with a local bisect.
Original issue's description:
> Added an extra sync token field for extra command buffer identification.
>
> This CL adds an extra field within sync tokens without changing the size
> of the sync token. Currently this extra field is only used for the
> GPU channel implementation, storing the stream of the identified command
> buffer.
>
> BUG=514815
>
> Committed: https://crrev.com/f21e7e6e2b260d56fa54373dd662c81c9d955331
> Cr-Commit-Position: refs/heads/master@{#363231}
TBR=dcheng@chromium.org,dalecurtis@chromium.org,piman@chromium.org,sky@chromium.org,dyen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=514815
Committed: https://crrev.com/5097a2103f86741a7d0e6567e57759be939182b0
Cr-Commit-Position: refs/heads/master@{#363290}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|